This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
remove connected disconnected state only #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
added
A0-please_review
This was referenced Sep 17, 2021
Lldenaurois
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
I think there are a few places where we are explicit about the type, but needn't be,
e.g. let this: Option<_> = opt.map(...);
But I'm also not sure whether it's not better to be explicit in cases where you are returning an option or some other specific type.
I can see arguments for both, but I generally like to be as terse as possible. The type annotations are helpful to the reader, however.
drahnr
commented
Sep 17, 2021
eskimor
approved these changes
Sep 17, 2021
rphmeier
deleted the
bernhard-remove-connected-disconnected-state-only
branch
ordian
reviewed
Sep 20, 2021
| @@ -850,8 +914,10 @@ where | |||
| local_keystore.and_then(move |k| authority_discovery_service.map(|a| (a, k))); | |||
|
|
|||
| let overseer_handle = if let Some((authority_discovery_service, keystore)) = maybe_params { | |||
| let (overseer, overseer_handle) = overseer_gen | |||
| // already have access to the handle | |||
| let (overseer, _handle) = overseer_gen | |||
There was a problem hiding this comment.
why is _handle here dropped? because handle is its clone?
ghost
pushed a commit
that referenced
this pull request
Sep 20, 2021
ordian
added a commit
that referenced
this pull request
Sep 20, 2021
* master: Bump `parity-util-mem` to 0.10.2 (#3897) Revert "remove connected disconnected state only (#3868)" (#3896) Companion for Generate storage info for pallet im_online #9654 (#3744) Gather memory usage statistics through `parity-util-mem` (#3893) ci: cache seed in fuzzer job (#3885) Add benchmarking for parachain runtime configuration pallet (#3862) Run fmt (#3887) remove connected disconnected state only (#3868)
ordian
added a commit
that referenced
this pull request
Sep 21, 2021
* master: weights: pallet-staking & pallet-bags-list (#3872) Re-enable metadata compare CI check (#3895) Bump `parity-util-mem` to 0.10.2 (#3897) Revert "remove connected disconnected state only (#3868)" (#3896) Companion for Generate storage info for pallet im_online #9654 (#3744) Gather memory usage statistics through `parity-util-mem` (#3893) ci: cache seed in fuzzer job (#3885) Add benchmarking for parachain runtime configuration pallet (#3862) Run fmt (#3887) remove connected disconnected state only (#3868) Dispute distribution improvements (#3853) Companion for Store voters in unsorted bags to get good stake iteration properties (#3413) Add info logging to dispute activation (#3870) update Rococo.json (#3871) Companion for #9764 (Force Unreserve) (#3840)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces #3803 to the essential change-set to simplify review
Closes #3777
Renames:
RelayChainSelectionWithFallback->RelayChainSelectionRelayChainSelection->RelayChainSelectionInnerAdds:
OverseerConnectorusageBasicsRemoves:
OverseerConnected/Disconnectedstate handling and uses aboolis_relay_chaininstead