This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
collect included disputes from on-chain #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
added
A3-in_progress
drahnr
force-pushed
the
bernhard-collect-on-chain-disputes
branch
3 times, most recently
from
803ec4c
to
6d716d7
Compare
drahnr
force-pushed
the
bernhard-collect-on-chain-disputes
branch
from
6d716d7
to
b8cf3cd
Compare
drahnr
force-pushed
the
bernhard-collect-on-chain-disputes
branch
from
b8cf3cd
to
1b6a837
Compare
rphmeier
reviewed
Sep 29, 2021
drahnr
added
the
D3-trivial 🧸
drahnr
commented
Oct 4, 2021
drahnr
added
A0-please_review
rphmeier
reviewed
Oct 4, 2021
rphmeier
reviewed
Oct 4, 2021
rphmeier
reviewed
Oct 4, 2021
rphmeier
reviewed
Oct 4, 2021
rphmeier
reviewed
Oct 4, 2021
rphmeier
reviewed
Oct 4, 2021
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
rphmeier
approved these changes
Oct 5, 2021
4 tasks
eskimor
approved these changes
Oct 6, 2021
| return Ok(()) | ||
| }, | ||
| Ok(Err(e)) => { | ||
| tracing::debug!( |
There was a problem hiding this comment.
As this probably can come from a runtime upgrade, it should probably be warn?
There was a problem hiding this comment.
No, it should be debug IMO otherwise the logs will constantly be filled with warn! until we upgrade the runtime to include this.
There was a problem hiding this comment.
Fair, but should we make it warn once the runtime got upgraded? Follow up issue?
| .validators | ||
| .get(validator_index.0 as usize) | ||
| .or_else(|| { | ||
| tracing::error!( |
|
Looks pretty good! |
ordian
reviewed
Oct 6, 2021
| @@ -41,6 +42,7 @@ const SESSION_INFO_CACHE_SIZE: usize = 64 * 1024; | |||
| const DMQ_CONTENTS_CACHE_SIZE: usize = 64 * 1024; | |||
| const INBOUND_HRMP_CHANNELS_CACHE_SIZE: usize = 64 * 1024; | |||
| const CURRENT_BABE_EPOCH_CACHE_SIZE: usize = 64 * 1024; | |||
| const ON_CHAIN_VOTES_CACHE_SIZE: usize = 3 * 1024; | |||
There was a problem hiding this comment.
any reason for choosing 3KiB for cache size? the lowest we have is 64KiB, but it's not really backed by data
There was a problem hiding this comment.
No particular reason. We simply won't use it that much, so this could be an optimization to remove it.
|
bot merge |
|
Trying merge. |
ghost
merged commit 
19 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
runtime_impl::imported_disputes()-fns.imported_disputeson the node side, so older runtime versions that do not provide the call, do not take down the node.