This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add more XCM tracing #4211
Merged
Add more XCM tracing #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
added
B0-silent
KiChjang
reviewed
Nov 3, 2021
| @@ -83,15 +83,44 @@ impl<Config: config::Config> ExecuteXcm<Config::Call> for XcmExecutor<Config> { | |||
| ); | |||
| let xcm_weight = match Config::Weigher::weight(&mut message) { | |||
| Ok(x) => x, | |||
| Err(()) => return Outcome::Error(XcmError::WeightNotComputable), | |||
| Err(()) => { | |||
| log::debug!( | |||
There was a problem hiding this comment.
Cause I was thinking that it would be nice to get the most important subset of the logging via -lxcm=debug
shawntabrizi
approved these changes
Nov 10, 2021
|
bot merge |
ordian
added a commit
that referenced
this pull request
Nov 11, 2021
* master: CI: chore (#3957) Companion – Update jsonrpsee to 0.4.1 (#4256) Add more XCM tracing (#4211) Update dependencies for latest substrate master (#4258) Bump mick-jaeger from 0.1.4 to 0.1.6 (#4249) Bump dlmalloc from 0.2.2 to 0.2.3 (#4250) Bump libc from 0.2.106 to 0.2.107 (#4235) Bump paste from 1.0.5 to 1.0.6 (#4244) Bump serde_json from 1.0.68 to 1.0.69 (#4236)
ordian
added a commit
that referenced
this pull request
Nov 12, 2021
* master: (71 commits) Remove light client companion (#4191) Enable full use of pallet-bags-list in westend and kusama runtimes (#4195) collator-protocol: do not connect to the next group (#4261) Per subsystem CPU usage tracking (#4239) CI: chore (#3957) Companion – Update jsonrpsee to 0.4.1 (#4256) Add more XCM tracing (#4211) Update dependencies for latest substrate master (#4258) Bump mick-jaeger from 0.1.4 to 0.1.6 (#4249) Bump dlmalloc from 0.2.2 to 0.2.3 (#4250) Bump libc from 0.2.106 to 0.2.107 (#4235) Bump paste from 1.0.5 to 1.0.6 (#4244) Bump serde_json from 1.0.68 to 1.0.69 (#4236) Update `wasmtime` and related dependencies (companion for Substrate#10149) (#4210) update cargo lock to unbreak dep of a dep (#4245) Increase maximum chunk size to adjust for small networks. (#4220) availability recovery type name clarifications (#4203) Update `bridge/` codeowners (#4222) fix(staking miner): use `StorageKey` in getStorage (#4231) Change path for the tests to master (#4223) ...
drahnr
pushed a commit
that referenced
this pull request
Nov 15, 2021
* add more logging to currency adapter * add more logging to barriers * reformat currency adapter trace logs * add tracing logs for filter asset location * add tracing logs to fungibles adapter * add tracing to origin conversion * add tracing logs for xcm weight trading * fix compile errors * add more tracing logs to xcm executor * formatting and compile fixes * add some tracing logs to pallet-xcm * adjust log target in executor to debug * fix closure args
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tracing to different parts of XCM.
Feedback wanted on:
Usage
As with #3353 add
-lxcm=traceto any Polkadot node. With the new traces this might get noisy, so you can reduce to-lxcm=debugif you would like fewer logs.