Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

introduce trusted teleporter Encointer for Rococo and Westend #4213

Merged
merged 1 commit into from
Dec 15, 2021
Merged

introduce trusted teleporter Encointer for Rococo and Westend #4213

merged 1 commit into from
Dec 15, 2021

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Nov 3, 2021

After discussion with @gavofyork, we have adjusted our common good parachain governance model. As desired for common good, there will be no root origin on the parachain and with this PR we'd like to be included in the trusted teleport set.

We believe this is in line with Kusama council's decision to accept Encointer as a common good:
Discussion: https://kusama.polkassembly.io/post/610
Executed signalling motion: https://kusama.polkassembly.io/motion/357

As discussed with @joepetrowski, we'd test teleport on rococo first and wait for this PR to enter a release before testing teleport and set_code on westmint

@joepetrowski may I ask for your review? Should this work?

@brenzi brenzi changed the title introduce trusted parachain Encointer introduce trusted teleporter Encointer Nov 3, 2021
@joepetrowski
Copy link
Contributor

Looks OK to me. set_code can be tested independently of teleportation.

@brenzi
Copy link
Contributor Author

brenzi commented Nov 3, 2021

was able to teleport from rococo-local (this PR) to our parachain master: https://github.com/encointer/encointer-parachain
backwards didn't work because of a decoding failure in js/apps

@brenzi brenzi mentioned this pull request Nov 3, 2021
Closed
2 tasks
@brenzi brenzi changed the title introduce trusted teleporter Encointer introduce trusted teleporter Encointer for Rococo and Westend Nov 5, 2021
@joepetrowski joepetrowski added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Nov 8, 2021
KiChjang
KiChjang approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a strong opinion with test networks; anyone should be able to just configure themselves be a trusted teleporter.

@KiChjang
Copy link
Contributor

KiChjang commented Nov 8, 2021 •
edited
Loading

Just one thing though: Westend doesn't allow for unpaid executions from anything other than a system parachain, whereas in this PR for Rococo, you've explicitly whitelisted Encointer for the barrier. Is this sufficient for your testing purposes?

@brenzi
Copy link
Contributor Author

brenzi commented Nov 8, 2021 •
edited
Loading

@KiChjang Our parachain comes without a root origin and starts with zero token supply (apart from the ED for the treasury account). What we need for testing is:

  • teleport relaychain tokens to our parachain. Otherwise we can't send extrinsics at all
  • runtime upgrade through relaychain

That would be enough ATM

@KiChjang
Copy link
Contributor

KiChjang commented Nov 9, 2021

Okay, just making sure that you're aware that Westend has a different barrier condition from Rococo, i.e. if you're ever getting a Barrier error on Westend, try testing on Rococo and see if it resolves your issues.

@brenzi brenzi force-pushed the add-encointer-trusted-teleport branch from 1bbf029 to 141d65b Compare November 28, 2021 10:16
@brenzi
Copy link
Contributor Author

brenzi commented Nov 28, 2021

rebased on polkadot-0.9.13

@brenzi brenzi mentioned this pull request Nov 29, 2021
Merged
@brenzi brenzi force-pushed the add-encointer-trusted-teleport branch from 141d65b to 2c36766 Compare December 11, 2021 13:40
@brenzi
Copy link
Contributor Author

brenzi commented Dec 11, 2021

Now that Encointer has been ratified to become a common good parachain on Kusama, can we merge this for the next runtime upgrade?
see #4401 too

@joepetrowski joepetrowski merged commit cf433f5 into paritytech:master Dec 15, 2021
ordian added a commit that referenced this pull request Dec 16, 2021
@ordian
Merge branch 'master' into pep-primitives-constants-notice
68dc2a2 
* master:
  Bump tokio from 1.14.0 to 1.15.0 (#4537)
  Bump mick-jaeger from 0.1.6 to 0.1.7 (#4538)
  Versi chainspec based on Rococo. (#4485)
  Bump proc-macro2 from 1.0.33 to 1.0.34 (#4526)
  fix compile with new compiler - dead code (#4530)
  introduce trusted parachain Encointer for rococo and westend (#4213)
  add Encointer TrustedTeleporter (#4401)
  Bump libc from 0.2.109 to 0.2.112 (#4522)
  Bump serde_json from 1.0.72 to 1.0.73 (#4523)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joepetrowski joepetrowski joepetrowski approved these changes

@KiChjang KiChjang KiChjang approved these changes

@acatangiu acatangiu Awaiting requested review from acatangiu

@adoerr adoerr Awaiting requested review from adoerr

@antonio-dropulic antonio-dropulic Awaiting requested review from antonio-dropulic

@svyatonik svyatonik Awaiting requested review from svyatonik

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brenzi @joepetrowski @KiChjang