This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Do not allow death on Crowdloan contribute + Introduce contribute_all
#4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B7-runtimenoteworthy
C1-low
sorpaas
approved these changes
Nov 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have been complaining that the
AllowDeathflag on crowdloan contributions is unexpected and has been eating dust out of accounts when users do not contribute the full amount into the crowdloan.This PR changes the
AllowDeathflag oncontributetoKeepAlive, which forces the user to keep the existential deposit of funds in their account after the crowdloan contribution.As an alternative option, users can now also call
contribute_all, which automatically calculates the full balance available to transfer from the user, and contributes that to the crowdloan while allowing death of the account.Ideally, before this PR goes in, or instead of accepting this PR, UIs which handle crowdloan contributions would do the same logic.