This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
remove provisioner checks #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-remove-provisioner-checks
branch
from
0ebde42
to
db42146
Compare
drahnr
added
A3-in_progress
drahnr
force-pushed
the
bernhard-remove-provisioner-checks
branch
from
29b0374
to
ed45994
Compare
emostov
reviewed
Nov 11, 2021
Lldenaurois
approved these changes
Nov 11, 2021
emostov
reviewed
Nov 15, 2021
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
emostov
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
The code itself looks good. But in the future I wonder if there would be a performance optimization to share the sanitize_* functions between the provisioner and the runtime.
From my understanding, all the filtering in the runtime will be running in wasm, were as if we do filtering in the node it will run in native. If we can consistently decrease the inherent data size before it hits the wasm runtime I wonder if we would get some performance gains?
|
Any implementer's guide updates? |
|
Amended the guide. Added another trivial check to bound the |
ordian
approved these changes
Nov 19, 2021
ordian
reviewed
Nov 19, 2021
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Andronik Ordian <write@reusable.software>
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
bernhard-remove-provisioner-checks
branch
ordian
added a commit
that referenced
this pull request
Nov 20, 2021
* master: (38 commits) Replicate Rob's PR (#4337) Companion for Taskmanager: Remove `clean_shutdown` (#4336) prefer code upgrades in inherent filtering (#4334) remove provisioner checks (#4254) Log para inherent inputs (#4331) Dispute spam protection (#4134) Dependabot: Ignore sub-tokens (#4328) export hrmp config (#4324) Add missing license header (#4321) Use non-empty validation code (#4322) fix pallet-xcm extrinsic doc comments (#4317) prepare worker: Catch unexpected unwinds (#4304) Enable BEEFY explicitly (#4320) Bump serde_json from 1.0.70 to 1.0.71 (#4316) Bump strum from 0.22.0 to 0.23.0 (#4308) Remove sort_unstable_by (#4314) Bump tokio from 1.13.0 to 1.14.0 (#4298) Substrate companion: Authority discovery multiple peer ids (#4295) Companion for substrate#9878 (#3949) move paras inherent filtering to runtime (#4028) ...
Lldenaurois
added a commit
that referenced
this pull request
Nov 25, 2021
This reverts commit 71e7670.
Lldenaurois
added a commit
that referenced
this pull request
Nov 29, 2021
This reverts commit 71e7670.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the node-side checks that now exist as part of the runtime.
Complements and requires #4028
Closes #3989
skip check-dependent-cumulus