Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update event variants #4262

Conversation

Wizdave97
Copy link
Contributor

@Wizdave97 Wizdave97 commented Nov 11, 2021

This is a Companion PR to paritytech/substrate#9993

cumulus companion: paritytech/cumulus#749

@KiChjang
Copy link
Contributor

Need to run cargo +nightly fmt.

@Wizdave97 Wizdave97 force-pushed the wiz/add-field-names-to-pallet-events branch from 2295310 to 46510b1 Compare November 12, 2021 06:51
@Wizdave97
Copy link
Contributor Author

Wizdave97 commented Nov 12, 2021

Need to run cargo +nightly fmt.

Done, don't know why the cago fmt CI is still failing

@Wizdave97 Wizdave97 force-pushed the wiz/add-field-names-to-pallet-events branch from 532a424 to c1cd9ef Compare November 12, 2021 07:26
Comment on lines +357 to +359
Event::Democracy(democracy::Event::Passed { ref_index: _index })
if _index == ref_index =>
true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should've just used:

Suggested change
Event::Democracy(democracy::Event::Passed { ref_index: _index })
if _index == ref_index =>
true,
Event::Democracy(democracy::Event::Passed { ref_index: _index }) => _index == ref_index,

instead of using a match guard. Same for the ones below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but better not to try to refactor too much in these kind of PR, in case one refactor is wrong, it will be easily missed.
I like that this PR only does what it is supposed to.

Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big issues; simple nits that shouldn't really block this PR from landing.

@paritytech-processbot
Copy link

Companion update failed: CommandFailed { cmd: "Command { std: "cargo" "update" "-v" "-p" "sc-tracing-proc-macro:4.0.0-dev" "-p" "pallet-tips:4.0.0-dev" "-p" "sp-blockchain:4.0.0-dev" "-p" "sc-executor-wasmtime:0.10.0-dev" "-p" "frame-support-test:3.0.0" "-p" "sc-finality-grandpa-rpc:0.10.0-dev" "-p" "sc-executor-common:0.10.0-dev" "-p" "sp-consensus:0.10.0-dev" "-p" "sp-serializer:4.0.0-dev" "-p" "sc-basic-authorship:0.10.0-dev" "-p" "frame-system-benchmarking:4.0.0-dev" "-p" "sc-block-builder:0.10.0-dev" "-p" "sc-allocator:4.1.0-dev" "-p" "pallet-bounties:4.0.0-dev" "-p" "sc-rpc:4.0.0-dev" "-p" "pallet-utility:4.0.0-dev" "-p" "frame-benchmarking-cli:4.0.0-dev" "-p" "pallet-babe:4.0.0-dev" "-p" "sc-finality-grandpa:0.10.0-dev" "-p" "pallet-elections-phragmen:5.0.0-dev" "-p" "sc-client-db:0.10.0-dev" "-p" "sp-panic-handler:4.0.0-dev" "-p" "sc-executor-wasmi:0.10.0-dev" "-p" "pallet-grandpa:4.0.0-dev" "-p" "sp-keyring:4.0.0-dev" "-p" "sc-chain-spec-derive:4.0.0-dev" "-p" "pallet-timestamp:4.0.0-dev" "-p" "sc-consensus-epochs:0.10.0-dev" "-p" "sc-network-gossip:0.10.0-dev" "-p" "sp-offchain:4.0.0-dev" "-p" "sp-wasm-interface:4.0.0-dev" "-p" "pallet-nicks:4.0.0-dev" "-p" "sp-npos-elections:4.0.0-dev" "-p" "beefy-merkle-tree:4.0.0-dev" "-p" "frame-election-provider-support:4.0.0-dev" "-p" "pallet-gilt:4.0.0-dev" "-p" "frame-system:4.0.0-dev" "-p" "sc-peerset:4.0.0-dev" "-p" "sc-service:0.10.0-dev" "-p" "sp-keystore:0.10.0-dev" "-p" "pallet-election-provider-multi-phase:4.0.0-dev" "-p" "frame-support-procedural-tools-derive:3.0.0" "-p" "sc-chain-spec:4.0.0-dev" "-p" "sc-transaction-pool-api:4.0.0-dev" "-p" "sp-core:4.0.0-dev" "-p" "substrate-wasm-builder:5.0.0-dev" "-p" "try-runtime-cli:0.10.0-dev" "-p" "generate-bags:4.0.0-dev" "-p" "sp-state-machine:0.10.0-dev" "-p" "sc-client-api:4.0.0-dev" "-p" "pallet-mmr-rpc:3.0.0" "-p" "sp-tasks:4.0.0-dev" "-p" "substrate-prometheus-endpoint:0.10.0-dev" "-p" "pallet-staking:4.0.0-dev" "-p" "sp-api-proc-macro:4.0.0-dev" "-p" "sc-proposer-metrics:0.10.0-dev" "-p" "substrate-test-client:2.0.1" "-p" "sc-executor:0.10.0-dev" "-p" "pallet-beefy-mmr:4.0.0-dev" "-p" "pallet-society:4.0.0-dev" "-p" "sp-core-hashing:4.0.0-dev" "-p" "sc-cli:0.10.0-dev" "-p" "pallet-transaction-payment:4.0.0-dev" "-p" "sp-consensus-slots:0.10.0-dev" "-p" "sp-version:4.0.0-dev" "-p" "sc-consensus-babe-rpc:0.10.0-dev" "-p" "sp-database:4.0.0-dev" "-p" "substrate-build-script-utils:3.0.0" "-p" "sc-authority-discovery:0.10.0-dev" "-p" "pallet-mmr:4.0.0-dev" "-p" "pallet-recovery:4.0.0-dev" "-p" "sp-block-builder:4.0.0-dev" "-p" "substrate-frame-rpc-system:4.0.0-dev" "-p" "sp-finality-grandpa:4.0.0-dev" "-p" "pallet-collective:4.0.0-dev" "-p" "sp-session:4.0.0-dev" "-p" "pallet-offences:4.0.0-dev" "-p" "sp-core-hashing-proc-macro:4.0.0-dev" "-p" "pallet-bags-list-remote-tests:4.0.0-dev" "-p" "frame-support:4.0.0-dev" "-p" "sp-externalities:0.10.0-dev" "-p" "sp-version-proc-macro:4.0.0-dev" "-p" "pallet-im-online:4.0.0-dev" "-p" "pallet-transaction-payment-rpc-runtime-api:4.0.0-dev" "-p" "sc-network:0.10.0-dev" "-p" "fork-tree:3.0.0" "-p" "frame-try-runtime:0.10.0-dev" "-p" "pallet-scheduler:4.0.0-dev" "-p" "pallet-proxy:4.0.0-dev" "-p" "pallet-democracy:4.0.0-dev" "-p" "frame-support-test-pallet:4.0.0-dev" "-p" "sc-consensus-babe:0.10.0-dev" "-p" "sc-offchain:4.0.0-dev" "-p" "pallet-treasury:4.0.0-dev" "-p" "sc-consensus-manual-seal:0.10.0-dev" "-p" "pallet-transaction-payment-rpc:4.0.0-dev" "-p" "pallet-authority-discovery:4.0.0-dev" "-p" "sp-storage:4.0.0-dev" "-p" "pallet-staking-reward-curve:4.0.0-dev" "-p" "sp-authority-discovery:4.0.0-dev" "-p" "sp-runtime-interface:4.0.0-dev" "-p" "pallet-multisig:4.0.0-dev" "-p" "frame-support-procedural:4.0.0-dev" "-p" "pallet-mmr-primitives:4.0.0-dev" "-p" "remote-externalities:0.10.0-dev" "-p" "frame-system-rpc-runtime-api:4.0.0-dev" "-p" "sc-state-db:0.10.0-dev" "-p" "sp-std:4.0.0-dev" "-p" "test-runner:0.9.0" "-p" "sc-utils:4.0.0-dev" "-p" "sp-arithmetic:4.0.0-dev" "-p" "sc-tracing:4.0.0-dev" "-p" "beefy-gadget:4.0.0-dev" "-p" "frame-support-procedural-tools:4.0.0-dev" "-p" "beefy-primitives:4.0.0-dev" "-p" "sc-informant:0.10.0-dev" "-p" "frame-benchmarking:4.0.0-dev" "-p" "sp-inherents:4.0.0-dev" "-p" "sp-io:4.0.0-dev" "-p" "sp-staking:4.0.0-dev" "-p" "sp-timestamp:4.0.0-dev" "-p" "sp-transaction-pool:4.0.0-dev" "-p" "substrate-test-utils:4.0.0-dev" "-p" "pallet-session-benchmarking:4.0.0-dev" "-p" "sc-sync-state-rpc:0.10.0-dev" "-p" "frame-executive:4.0.0-dev" "-p" "pallet-balances:4.0.0-dev" "-p" "sp-debug-derive:4.0.0-dev" "-p" "sp-authorship:4.0.0-dev" "-p" "sp-consensus-babe:0.10.0-dev" "-p" "sp-tracing:4.0.0-dev" "-p" "sp-trie:4.0.0-dev" "-p" "sc-transaction-pool:4.0.0-dev" "-p" "substrate-test-utils-derive:0.10.0-dev" "-p" "pallet-bags-list:4.0.0-dev" "-p" "sp-runtime:4.0.0-dev" "-p" "sp-npos-elections-solution-type:4.0.0-dev" "-p" "beefy-gadget-rpc:4.0.0-dev" "-p" "pallet-membership:4.0.0-dev" "-p" "sc-rpc-api:0.10.0-dev" "-p" "sc-consensus-slots:0.10.0-dev" "-p" "pallet-beefy:4.0.0-dev" "-p" "sp-transaction-storage-proof:4.0.0-dev" "-p" "sc-telemetry:4.0.0-dev" "-p" "sp-maybe-compressed-blob:4.1.0-dev" "-p" "sc-consensus:0.10.0-dev" "-p" "pallet-staking-reward-fn:4.0.0-dev" "-p" "sc-rpc-server:4.0.0-dev" "-p" "sp-rpc:4.0.0-dev" "-p" "sp-application-crypto:4.0.0-dev" "-p" "pallet-offences-benchmarking:4.0.0-dev" "-p" "pallet-session:4.0.0-dev" "-p" "pallet-sudo:4.0.0-dev" "-p" "sc-keystore:4.0.0-dev" "-p" "sp-runtime-interface-proc-macro:4.0.0-dev" "-p" "pallet-identity:4.0.0-dev" "-p" "pallet-indices:4.0.0-dev" "-p" "pallet-vesting:4.0.0-dev" "-p" "sp-api:4.0.0-dev" "-p" "sc-consensus-uncles:0.10.0-dev" "-p" "pallet-authorship:4.0.0-dev" "-p" "pallet-assets:4.0.0-dev" "-p" "sp-consensus-vrf:0.10.0-dev", kill_on_drop: false }", status_code: Some(101), err: " Updating git repository https://github.com/paritytech/substrate\n Updating crates.io index\nerror: no matching package named frame-benchmarking-cli found\nlocation searched: https://github.com/paritytech/substrate?branch=master\nrequired by package polkadot-cli v0.9.13 (/builds/polkadot/cli)\n" }

@gui1117 gui1117 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Nov 16, 2021
@gui1117
Copy link
Contributor

gui1117 commented Nov 16, 2021

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit a711993 into paritytech:master Nov 16, 2021
@Wizdave97 Wizdave97 deleted the wiz/add-field-names-to-pallet-events branch November 16, 2021 08:36
bkchr pushed a commit that referenced this pull request Nov 30, 2021
* update event variants

* fmt

* fixes

* update substrate

Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants