parachains: Fix configuration module #4540

pepyakin · 2021-12-16T13:15:42Z

Closes #4529
Closes #4533

I figured that trying to avoid updates does not really worth it to keep.
This is because we seem to not update the configuration often and when
we do we approach this carefully. Thus possibility of a redundant update
is really negligable. At the same time, if such a redundant update does
happen then the effects of that are really small: just some wasted
storage interactions.

On the other hand, making it work was a little bit annoying. With the
proper fix for the pending updates this would be even more annoying
since now we would have to add combinatorically more cases to test this.

So I figured that I will just scrap that and simplify the code.

Runtime Migration

This PR doesn't introduce a new runtime migration but rather fixes the migration code introduced in #4420

skip check-dependent-cumulus

pepyakin · 2021-12-16T13:15:51Z

Current dependencies on/for this PR:

master
- PR parachains: Fix configuration module #4540 (this PR)
  - PR configuration: refactor configuration initialization #4569

This comment was auto-generated by Graphite.

pepyakin · 2021-12-16T16:30:00Z

/benchmark runtime kusama runtime_parachains::configuration

parity-benchapp · 2021-12-16T16:30:02Z

Benchmark Runtime Kusama Pallet for branch "pep-configuration-fixes" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_configuration.rs

Results

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_block_number", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=     8.24
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=     8.24
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.123
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.123
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_option_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.547
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.547
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_weight", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.379
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.379
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_hrmp_open_request_ttl", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Benchmark Override (r:0 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_balance", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=      8.4
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=      8.4
              µs

Reads = 3
Writes = 1

pepyakin · 2021-12-16T17:24:49Z

/benchmark runtime polkadot runtime_parachains::configuration

parity-benchapp · 2021-12-16T17:24:50Z

Benchmark Runtime Polkadot Pallet for branch "pep-configuration-fixes" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_configuration.rs

Results

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_block_number", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.144
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.144
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=      8.1
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=      8.1
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_option_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.146
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.146
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_weight", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.716
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.716
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_hrmp_open_request_ttl", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Benchmark Override (r:0 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_balance", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.735
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.735
              µs

Reads = 3
Writes = 1

pepyakin · 2021-12-16T17:42:10Z

/benchmark runtime westend runtime_parachains::configuration

parity-benchapp · 2021-12-16T17:42:12Z

Benchmark Runtime Westend Pallet for branch "pep-configuration-fixes" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_configuration.rs

Results

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_block_number", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.735
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.735
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.824
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.824
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_option_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.121
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.121
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_weight", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.011
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.011
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_hrmp_open_request_ttl", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Benchmark Override (r:0 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_balance", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.954
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.954
              µs

Reads = 2
Writes = 1

pepyakin · 2021-12-16T18:17:35Z

/benchmark runtime custom --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_configuration.rs

parity-benchapp · 2021-12-16T18:17:37Z

Benchmark Runtime Custom for branch "pep-configuration-fixes" with command cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_configuration.rs

Results

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_block_number", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.015
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.015
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.054
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.054
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_option_u32", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.122
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.122
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_weight", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.339
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.339
              µs

Reads = 3
Writes = 1

Pallet: "runtime_parachains::configuration", Extrinsic: "set_hrmp_open_request_ttl", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Benchmark Override (r:0 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=  2000000
              µs

Reads = 0
Writes = 0

Pallet: "runtime_parachains::configuration", Extrinsic: "set_config_with_balance", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration PendingConfigs (r:1 w:1)
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: ParasShared CurrentSessionIndex (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.284
              µs

Reads = 3
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    8.284
              µs

Reads = 3
Writes = 1

shawntabrizi · 2021-12-17T00:07:03Z

runtime/parachains/src/configuration.rs

+	pub(crate) type PendingConfigs<T: Config> =
+		StorageValue<_, Vec<(SessionIndex, HostConfiguration<T::BlockNumber>)>, ValueQuery>;


if it can only contain 2 items, why not use a fixed size array?

What would that give though? At the same time, it would be more annoying to change if we were to change the SESSION_DELAY.

No specific reason, just thinking that if you are going to have some specific constraint about this storage item, that we can just program that in.

Yeah, I am generally pro making it more typesafe, but I believe here it does not provide much benefit while can be potential problem in the future (although I admit that it is also not super likely we will change SESSION_DELAY)

runtime/parachains/src/configuration.rs

shawntabrizi

looking good to me

Closes #4529 Closes #4533 I figured that trying to avoid updates does not really worth it to keep. This is because we seem to not update the configuration often and when we do we approach this carefully. Thus possibility of a redundant update is really negligable. At the same time, if such a redundant update does happen then the effects of that are really small: just some wasted storage interactions. On the other hand, making it work was a little bit annoying. With the proper fix for the pending updates this would be even more annoying since now we would have to add combinatorically more cases to test this. So I figured that I will just scrap that and simplify the code.

…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_configuration.rs

…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_configuration.rs

…k --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_configuration.rs

eskimor

LGTM

runtime/parachains/src/configuration.rs

pepyakin · 2021-12-21T13:07:00Z

This PR doesn't introduce a new runtime migration but rather fixes the code in the previously introduced one.

eskimor · 2021-12-21T13:27:58Z

bot merge

paritytech-processbot · 2021-12-21T13:28:06Z

Waiting for commit status.

This commit incorporates the changes made to the runtime in the following PRs: - #4408 - #4457 - #4540 - #4542 - #4581 Note that this PR does not include the description of the PVF pre-checker subsystem. This should be addressed within #4611

This commit incorporates the changes made to the runtime in the following PRs: - #4408 - #4457 - #4540 - #4542 - #4581 Note that this PR does not include the description of the PVF pre-checker subsystem. This should be addressed within #4611 Co-authored-by: sandreim <54316454+sandreim@users.noreply.github.com>

* parachains: Fix configuration module Closes #4529 Closes #4533 I figured that trying to avoid updates does not really worth it to keep. This is because we seem to not update the configuration often and when we do we approach this carefully. Thus possibility of a redundant update is really negligable. At the same time, if such a redundant update does happen then the effects of that are really small: just some wasted storage interactions. On the other hand, making it work was a little bit annoying. With the proper fix for the pending updates this would be even more annoying since now we would have to add combinatorically more cases to test this. So I figured that I will just scrap that and simplify the code. * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_configuration.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_configuration.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_configuration.rs * review fixes Co-authored-by: Parity Bot <admin@parity.io>

This commit incorporates the changes made to the runtime in the following PRs: - #4408 - #4457 - #4540 - #4542 - #4581 Note that this PR does not include the description of the PVF pre-checker subsystem. This should be addressed within #4611 Co-authored-by: sandreim <54316454+sandreim@users.noreply.github.com>

* parachains: Fix configuration module Closes paritytech#4529 Closes paritytech#4533 I figured that trying to avoid updates does not really worth it to keep. This is because we seem to not update the configuration often and when we do we approach this carefully. Thus possibility of a redundant update is really negligable. At the same time, if such a redundant update does happen then the effects of that are really small: just some wasted storage interactions. On the other hand, making it work was a little bit annoying. With the proper fix for the pending updates this would be even more annoying since now we would have to add combinatorically more cases to test this. So I figured that I will just scrap that and simplify the code. * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_configuration.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_configuration.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_configuration.rs * review fixes Co-authored-by: Parity Bot <admin@parity.io>

This commit incorporates the changes made to the runtime in the following PRs: - paritytech#4408 - paritytech#4457 - paritytech#4540 - paritytech#4542 - paritytech#4581 Note that this PR does not include the description of the PVF pre-checker subsystem. This should be addressed within paritytech#4611 Co-authored-by: sandreim <54316454+sandreim@users.noreply.github.com>

github-actions bot added the A0-please_review Pull request needs code review. label Dec 16, 2021

pepyakin added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Dec 16, 2021

pepyakin force-pushed the pep-configuration-fixes branch 2 times, most recently from 53415c9 to 2508785 Compare December 16, 2021 16:25

This comment has been minimized.

Sign in to view

shawntabrizi reviewed Dec 17, 2021

View reviewed changes

runtime/parachains/src/configuration.rs Outdated Show resolved Hide resolved

shawntabrizi reviewed Dec 17, 2021

View reviewed changes

runtime/parachains/src/configuration.rs Outdated Show resolved Hide resolved

shawntabrizi approved these changes Dec 17, 2021

View reviewed changes

pepyakin force-pushed the pep-configuration-fixes branch from 937b926 to 919c9f5 Compare December 17, 2021 13:55

pepyakin and others added 4 commits December 20, 2021 12:12

pepyakin force-pushed the pep-configuration-fixes branch from 919c9f5 to 4e47095 Compare December 20, 2021 12:51

pepyakin mentioned this pull request Dec 20, 2021

configuration: refactor configuration initialization #4569

Merged

eskimor approved these changes Dec 20, 2021

View reviewed changes

runtime/parachains/src/configuration.rs Outdated Show resolved Hide resolved

runtime/parachains/src/configuration.rs Show resolved Hide resolved

review fixes

1e40691

pepyakin force-pushed the pep-configuration-fixes branch from 4e47095 to 1e40691 Compare December 20, 2021 21:46

pepyakin added the E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. label Dec 21, 2021

pepyakin added this to the v0.9.16 milestone Dec 21, 2021

paritytech-processbot bot merged commit b3d0778 into master Dec 21, 2021

paritytech-processbot bot deleted the pep-configuration-fixes branch December 21, 2021 13:28

ordian modified the milestones: v0.9.16, v0.9.15 Dec 23, 2021

pepyakin mentioned this pull request Dec 27, 2021

pvf-precheck: update implementers' guide #4612

Merged

chevdor modified the milestones: v0.9.15, v0.9.16 Jan 11, 2022

librelois mentioned this pull request Feb 7, 2022

Update substrate/polkadot/cumulus from v0.9.15 to v0.9.16 moonbeam-foundation/moonbeam#1259

Closed

louismerlin added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

parachains: Fix configuration module #4540

parachains: Fix configuration module #4540

pepyakin commented Dec 16, 2021 •

edited

Loading

pepyakin commented Dec 16, 2021 •

edited

Loading

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading

shawntabrizi Dec 17, 2021

pepyakin Dec 17, 2021

shawntabrizi Dec 17, 2021

pepyakin Dec 17, 2021

shawntabrizi left a comment

eskimor left a comment

pepyakin commented Dec 21, 2021

eskimor commented Dec 21, 2021

paritytech-processbot bot commented Dec 21, 2021

		pub(crate) type PendingConfigs<T: Config> =
		StorageValue<_, Vec<(SessionIndex, HostConfiguration<T::BlockNumber>)>, ValueQuery>;

parachains: Fix configuration module #4540

parachains: Fix configuration module #4540

Conversation

pepyakin commented Dec 16, 2021 • edited Loading

Runtime Migration

pepyakin commented Dec 16, 2021 • edited Loading

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 • edited Loading

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 • edited Loading

pepyakin commented Dec 16, 2021

parity-benchapp bot commented Dec 16, 2021 • edited Loading

shawntabrizi Dec 17, 2021

Choose a reason for hiding this comment

pepyakin Dec 17, 2021

Choose a reason for hiding this comment

shawntabrizi Dec 17, 2021

Choose a reason for hiding this comment

pepyakin Dec 17, 2021

Choose a reason for hiding this comment

shawntabrizi left a comment

Choose a reason for hiding this comment

eskimor left a comment

Choose a reason for hiding this comment

pepyakin commented Dec 21, 2021

eskimor commented Dec 21, 2021

paritytech-processbot bot commented Dec 21, 2021

pepyakin commented Dec 16, 2021 •

edited

Loading

pepyakin commented Dec 16, 2021 •

edited

Loading

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading

parity-benchapp bot commented Dec 16, 2021 •

edited

Loading