This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
pvf-checker: enable subsystem on all chains #5977
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slumber
added
A0-please_review
slumber
commented
Sep 7, 2022
| @@ -801,7 +801,7 @@ where | |||
| let auth_or_collator = role.is_authority() || is_collator.is_collator(); | |||
| let requires_overseer_for_chain_sel = local_keystore.is_some() && auth_or_collator; | |||
|
|
|||
| let pvf_checker_enabled = !is_collator.is_collator() && chain_spec.is_versi(); | |||
| let pvf_checker_enabled = role.is_authority() && !is_collator.is_collator(); | |||
There was a problem hiding this comment.
In order to submit votes a node is required to be an active validator, enabling it otherwise will unnecessarily poll runtime at each activation.
ordian
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
To give people some more context: to enable PVF prechecking on Kusama and Polkadot, we would need to set a runtime parameter. Before we do that, we need to enable the node-side subsystem, which this PR does.
I believe it has been tested on Versi that with enabled subsystem but disabled runtime parameter, the behavior is as expected?
Yes, the subsystem will poll new pvfs for prechecking at each activation (there will be none). |
eskimor
approved these changes
Sep 8, 2022
ordian
added a commit
that referenced
this pull request
Sep 8, 2022
* master: zombienet: add BEEFY justifications import test (#5855) disputes rewards (#5862) pvf-checker: enable subsystem on all chains (#5977) Update Rococo to mirror Kusama (#5617) Update Substrate (#5981) Service: Use weak dependency features (#5966) Companion for paritytech/substrate#12183 (#5971) Bump docker/setup-buildx-action from 1.7.0 to 2.0.0 (#5976)
ordian
added a commit
to ordian/polkadot
that referenced
this pull request
Sep 12, 2022
* master: Sync versions with current release (v0.9.29) (paritytech#5982) zombienet: add BEEFY justifications import test (paritytech#5855) disputes rewards (paritytech#5862) pvf-checker: enable subsystem on all chains (paritytech#5977) Update Rococo to mirror Kusama (paritytech#5617) Update Substrate (paritytech#5981) Service: Use weak dependency features (paritytech#5966) Companion for paritytech/substrate#12183 (paritytech#5971) Bump docker/setup-buildx-action from 1.7.0 to 2.0.0 (paritytech#5976) [Companion] Metadata delete on dissolve_pool (paritytech#5955) Companion for: `try-runtime`::`follow-chain` - keep connection (paritytech#5968) Companion - Read babe config parameters from runtime (paritytech#5842) Double approval checking timeout. (paritytech#5951) Doc comments for metrics in provisioner (paritytech#5967)
1 task
arturgontijo
added a commit
that referenced
this pull request
Nov 2, 2022
* Fixes
* Spelling
* Fixes
* Fix codec index of VersionedXcm
* Allows to customize how calls are dispatched from XCM (#5657)
* CallDispatcher trait
* fmt
* unused import
* fix test-runtime
* remove JustDispatch type
* fix typo in test-runtime
* missing CallDispatcher
* more missing CallDispatcher
* Update comment `NoteAssetLocked` -> `NoteUnlockable`
* pin gha versions (#5916)
* Companion to Substrate PR 12006 (#5913)
* Fix import to make it compatible with https://github.com/paritytech/substrate/pull/12006
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Fix output file for updating weights in run_benches_for_runtime.sh (#5906)
* Bump hyper from 0.14.19 to 0.14.20 (#5901)
Bumps [hyper](https://github.com/hyperium/hyper) from 0.14.19 to 0.14.20.
- [Release notes](https://github.com/hyperium/hyper/releases)
- [Changelog](https://github.com/hyperium/hyper/blob/v0.14.20/CHANGELOG.md)
- [Commits](https://github.com/hyperium/hyper/compare/v0.14.19...v0.14.20)
---
updated-dependencies:
- dependency-name: hyper
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump proc-macro2 from 1.0.40 to 1.0.43 (#5878)
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.40 to 1.0.43.
- [Release notes](https://github.com/dtolnay/proc-macro2/releases)
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.40...1.0.43)
---
updated-dependencies:
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump indexmap from 1.9.0 to 1.9.1 (#5918)
Bumps [indexmap](https://github.com/bluss/indexmap) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/bluss/indexmap/releases)
- [Changelog](https://github.com/bluss/indexmap/blob/master/RELEASES.md)
- [Commits](https://github.com/bluss/indexmap/compare/1.9.0...1.9.1)
---
updated-dependencies:
- dependency-name: indexmap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: bump zombienet version (#5914)
* Fixes
* Fixes
* Send back empty votes + log in approval-voting in case candidate entry is missing. (#5925)
* Send back empty votes + log.
* Update node/core/approval-voting/src/lib.rs
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
* Bump async-trait from 0.1.56 to 0.1.57 (#5919)
Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.56 to 0.1.57.
- [Release notes](https://github.com/dtolnay/async-trait/releases)
- [Commits](https://github.com/dtolnay/async-trait/compare/0.1.56...0.1.57)
---
updated-dependencies:
- dependency-name: async-trait
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Clean up MigrateToV10 (#5921)
* Clean up MigrateToV10
* fixup
* update weights (#5911)
* rococo: update weigths
* polkadot: update weigths
* kusama: update weigths
* westend: update weights
Co-authored-by: parity-processbot <>
* Fix wrong logic. (#5931)
* Update Substrate to make companion check happy (#5934)
I merged some prs that require one manual update.
* use generated preimage weight (#5904)
* use generated preimage weight
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Companion for 12095 (#5924)
* Companion for 12095
* fix
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Bump futures-util from 0.3.21 to 0.3.23 (#5922)
* Bump futures-util from 0.3.21 to 0.3.23
Bumps [futures-util](https://github.com/rust-lang/futures-rs) from 0.3.21 to 0.3.23.
- [Release notes](https://github.com/rust-lang/futures-rs/releases)
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.21...0.3.23)
---
updated-dependencies:
- dependency-name: futures-util
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Fix deprecated warning
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* version bumps (0.9.28) (#5933)
* Bump crate versions
* Bump spec_version to 9280 for kusama
* Bump spec_version to 9280 for polkadot
* Bump spec_version to 9280 for rococo
* Bump spec_version to 9280 for westend
* update Cargo.lock
Co-authored-by: parity-processbot <>
* Fix some typos in dispute-coordinator (#5941)
* Change validation & collation protocol names to include genesis hash & fork id (#5876)
* fix cargo check -p polkadot-node-core-provisioner --all-features (#5942)
* Companion for Weight v1.5 (#5943)
* fix to latest substrate pr
* update weights
* cargo build -p polkadot-runtime-parachains
* fix xcm-builder
* fix import
* fix a bunch
* fix a bunch of weight stuff
* kusama compile
* unused
* builds
* maybe fix
* cargo test -p polkadot-runtime-parachains
* xcm simulator example
* fix tests
* xcm sim fuzz
* fix runtime tests
* remove unused
* fix integration tests
* scalar div
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Don't store available data on disputes (#5950)
* Don't store available data on disputes
If there are lots of disputes, this leads to blowing up disk space on
validators. Rob luckily remembered that we do store the full
availability in participation.
The argument in the code does not make too much sense with the current
implementation, as no validator will ever request anything else from us,
than the one piece we are meant to posess.
* Fix warnings.
* Fix compile warnings
* Remove redundant field.
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io>
* companion `try-state` (#5907)
* bunch of changes for now
* companion for sanity-checks
* Fix
* remove bridges
* better logging
* revert spec change
* fmt
* fix
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* [Feature] Make XCM benchmarks more reusable and remove a redundant bench (#5936)
* [Feature] Make XCM benchmarks more reusable and remove a redunant bench
* implement track balances flag
* little comment fix
* Revert "little comment fix"
This reverts commit 6d0d1bb4d74752aa518c4d71718c1b71673bcca8.
* Revert "implement track balances flag"
This reverts commit e7884cbc57d053c5d57a80aab4caa42e78cfdc17.
* fix unused
* Companion for Weight v1.5 Follow Up (#5949)
* updates
* remove new
* fix up some stuff
* fix cargo files
* fix
* fix template
* update lockfile for {"substrate"}
* Update block_weights.rs
* remove unused
* remove unused
Co-authored-by: parity-processbot <>
* candidate-validation: info logs on failure (#5957)
* Companion of paritytech/substrate#12157 (#5964)
* Remove RefTimeWeight
* Fixes
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Bump dlmalloc from 0.2.3 to 0.2.4 (#5927)
Bumps [dlmalloc](https://github.com/alexcrichton/dlmalloc-rs) from 0.2.3 to 0.2.4.
- [Release notes](https://github.com/alexcrichton/dlmalloc-rs/releases)
- [Commits](https://github.com/alexcrichton/dlmalloc-rs/compare/0.2.3...0.2.4)
---
updated-dependencies:
- dependency-name: dlmalloc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Reflect benchmarking fn signature change (#5959)
* Reflect benchmarking fn signature change
* fmt
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Use custom type for ProtocolName (#5963)
* Use new ProtocolName in peer_set.rs
* Use new ProtocolName for request-response protocols
* Use new ProtocolName in polkadot-network-bridge
* Import and conversion fixes
* Use ProtocolName re-exported in sc_network
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Doc comments for metrics in provisioner (#5967)
* Double approval checking timeout. (#5951)
* Companion - Read babe config parameters from runtime (#5842)
* Read babe config parameters from runtime
* Trigger pipeline
* Trigger pipeline (after PR title change)
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Companion for: `try-runtime`::`follow-chain` - keep connection (#5968)
* Adjust to the new API
* Remove mutability
* Async constructor
* unwrap result
* do not panic
* suggestion
* leftover
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* [Companion] Metadata delete on dissolve_pool (#5955)
* [Companion] Metadata delete on dissolve_pool
* deps upd
* merge
Co-authored-by: parity-processbot <>
* Bump docker/setup-buildx-action from 1.7.0 to 2.0.0 (#5976)
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1.7.0 to 2.0.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](https://github.com/docker/setup-buildx-action/compare/f211e3e9ded2d9377c8cadc4489a4e38014bc4c9...dc7b9719a96d48369863986a06765841d7ea23f6)
---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Companion for paritytech/substrate#12183 (#5971)
* Companion for paritytech/substrate#12183
* Fixes
* Fixes
* Fixes
* cargo fmt
* Fixes
* Fixes
* Fixes
* cargo fmt
* Update runtime/parachains/src/paras_inherent/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* update lockfile for {"substrate"}
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
* Service: Use weak dependency features (#5966)
* Service: Use weak dependency features
* Set rust version
* Update Substrate (#5981)
* Update Rococo to mirror Kusama (#5617)
* upgrade to kusama base
* rollback epoch and clean up
* Substitue DOLLARS with UNITS
* money constatns to mirror Kusama
* fixing typo in test
* scheduler+collective+membership+preimage
* treasury+democracy+bounties+child_bounties+society
* tips+claim+identity+elections_phragmen+vesting
* recovery+gilt
* proxy+slot+auction+registar+crowdloan
* babe+epoch_time modificaction
* xcm_config
* xcm_config fix
* constants
* fix conflicts 2
* fmt
* update xcm_config
* revert xcm_config change
* fixing benchmarks
* cargo.lock
* Revert "babe+epoch_time modificaction"
This reverts commit 982d220917d9b497d84124e2a40857aa1f1ebbec.
* fix benchamrks 2
* fix benchmarks 3
* typos
* miscelaneous
* fix constants test
* rollback comments
* rollback lease period
* fmt
* add ROC to spellcheck dictionary
* fix cargo.toml + fixes
* remove TODOs
* nit fix
* weights 1.5
* Bumping number of perm/temp slots available
Co-authored-by: al3mart <alejandro@parity.io>
Co-authored-by: alvicsam <alvicsam@gmail.com>
* pvf-checker: enable subsystem on all chains (#5977)
* Enable pvf checker on all chains
* Disable pvf checker for non-authorities
* disputes rewards (#5862)
* refactor backing points to only reward active set
* impl disputes::RewardValidators
* enable rewards on westend, kusama, polkadot
* fmt
* make dispute points same as backing
* disable on polkadot for now
* zombienet: add BEEFY justifications import test (#5855)
* zombienet: add BEEFY justifications import test
* bump zombienet image version
* zombienet: can't retrieve metrics when node paused
* bump zombienet image version to v1.2.54
Signed-off-by: acatangiu <adrian@parity.io>
* Sync versions with current release (v0.9.29) (#5982)
* Bump transaction_version for westend
* Bump transaction_version for rococo
* Bump transaction_version for kusama
* Bump transaction_version for polkadot
* Bump spec_version to 9290
* Bump crate versions
* remove stale polkadot call filter (#5969)
* Remove stale polkadot call filter
* fix build
* really fix it
* unused import
* Fix
Co-authored-by: parity-processbot <>
* update weights (sync with v0.9.29) (#5989)
* kusama: update weights
* polkadot: update weights
* westend: update weights
* rococo: update weights
* fixup
* revert block weights
* Companion for #11981 (#5915)
* Companion for #11981
* more renaming
* fmt
* fixes
* add generic type
* Companion for #11831
* fix
* revert changes
* Delete rename-outer-enum.diff
* revert
* Update run_benches_for_runtime.sh
* rename type Call & type Event
* passing tests
* fmt
* small fixes
* commit
* fix
* fmt
* commit
* error fixes
* fix
* small fix in test
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* remove RuntimeCall from pallet_grandpa
* last fix
* commit
* rename
* merge fix
* update lockfile for {"substrate"}
* cargo +nightly fmt
* fix
Co-authored-by: parity-processbot <>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Update Westend Trusted Teleporters (#5985)
* change para ID of collectives and remove encointer
* fmt
* Update cid to 0.8.6 (#5994)
* Update cid to 0.8.6
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Remove CanAuthorWith trait (#5986)
* Remove CanAuthorWith trait
CanAuthotWith trait removed. Also all dependencies, parameters, type
paramers were removed. This is related to removal of native runtime.
* update lockfile for {"substrate"}
* Ensure we use unique directories after the recent change to `new_temp_dir`
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <info@kchr.de>
* Companion for paritytech/substrate#12219 (#5987)
* Companion for paritytech/substrate#12219
* Fixes
* update lockfile for {"substrate"}
* Fixes
* cargo fmt
Co-authored-by: parity-processbot <>
* update memory-lru:0.1.1 (#6012)
* Co #11976: Enable rust features (#5983)
* Enable correct features
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Feature gate function
The expose_db function is currently feature gated with runtime-benchmarks.
After the related Substrate MR, this feature gate will actually *work*
as intended instead of doing nothing.
BUT then we also have to pass through the correct feature, hence this MR.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* update lockfile for {"substrate"}
* Fix bench features
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fix more features
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
* Bump enumn from 0.1.4 to 0.1.5 (#5938)
Bumps [enumn](https://github.com/dtolnay/enumn) from 0.1.4 to 0.1.5.
- [Release notes](https://github.com/dtolnay/enumn/releases)
- [Commits](https://github.com/dtolnay/enumn/compare/0.1.4...0.1.5)
---
updated-dependencies:
- dependency-name: enumn
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* node/core/pvf: strip some deps (#6016)
* Bump blake2 from 0.10.2 to 0.10.4 (#6019)
* [Substrate Companion] Part 1: add TargetList for validator ranking (#5930)
* [Substrate Companion] Part 1: add TargetList for validator ranking
* fix fmt
* don't change the pallet name
* eloquent migration
* fmt
* fix build
* update deps
* Cargo.lock conflicts resolved
* update deps
* Revert "update deps"
This reverts commit e0b07565854f9c66e5f30cdfe2c0a8f08457c96e.
* fix deps
Co-authored-by: kianenigma <kian@parity.io>
* Use correct file header for 'benchmark overhead' (#5984)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
* gossip-support: disconnect when we're no longer in other's reserved set (#6024)
* gossip-support: disconnect when we're no longer in the reserved set
* fmt
* Improved dispute votes import in provisioner (#5567)
* Add `DisputeState` to `DisputeCoordinatorMessage::RecentDisputes`
The new signature of the message is:
```
RecentDisputes(oneshot::Sender<Vec<(SessionIndex, CandidateHash, DisputeStatus)>>),
```
As part of the change also add `DispiteStatus` to
`polkadot_node_primitives`.
* Move dummy_signature() in primitives/test-helpers
* Enable staging runtime api on Rococo
* Implementation
* Move disputes to separate module
* Vote prioritisation
* Duplicates handling
* Double vote handling
* Unit tests
* Logs and metrics
* Code review feedback
* Fix ACTIVE/INACTIVE separation and update partition names
* Add `fn dispute_is_inactive` to node primitives and refactor `fn get_active_with_status()` logic
* Keep the 'old' logic if the staging api is not enabled
* Fix some comments in tests
* Add warning message if there are any inactive_unknown_onchain disputes
* Add file headers and remove `use super::*;` usage outside tests
* Adding doc comments
* Fix test methods names
* Fix staging api usage
* Fix `get_disputes` runtime function implementation
* Fix compilation error
* Fix arithmetic operations in tests
* Use smaller test data
* Rename `RuntimeApiRequest::StagingDisputes` to `RuntimeApiRequest::Disputes`
* Remove `staging-client` feature flag
* fmt
* Remove `vstaging` feature flag
* Some comments regarding the staging api
* Rename dispute selection modules in provisioner
with_staging_api -> prioritized_selection
without_staging_api -> random_selection
* Comments for staging api
* Comments
* Additional logging
* Code review feedback
process_selected_disputes -> into_multi_dispute_statement_set
typo
In trait VoteType: vote_value -> is_valid
* Code review feedback
* Fix metrics
* get_disputes -> disputes
* Get time only once during partitioning
* Fix partitioning
* Comments
* Reduce the number of hardcoded api versions
* Code review feedback
* Unused import
* Comments
* More precise log messages
* Code review feedback
* Code review feedback
* Code review feedback - remove `trait VoteType`
* Code review feedback
* Trace log for DisputeCoordinatorMessage::QueryCandidateVotes counter in vote_selection
* Adjust MultiAssets weights based on new wild card variants
* [ci] Revert cancel-pipeline job (#6028)
* [WIP][ci] Revert cancel-pipeline job
* fail test-linux-stable
* fix test-linux-stable
* runtime/disputes: slashing (#5535)
* disputes: runtime part of slashing
* disputes: reward winners
* disputes/slashing: validate_unsigned impl
* fmt
* disputes/slashing: report_dispute_lost_unsigned
* disputes/slashing: separate winners from losers and report winners
* disputes/slashing: refactoring
* impl HandleReports
* enable on Wenstend
* fmt
* add slashing pallet to the mock and test runtimes
* fix a bug in report_dispute_lost_unsigned
* fmt
* disputes: remove new_participants from summary
* disputes: remove punish_inconclusive
* impl SlashingHandler for Pallet for type-safety
* do not impl slashing::Config on mainnets yet
* teach spellcheck deduplication
* simplify interfaces and resolve some TODOs
* resolve some more TODOs
* minor typos
* move slashing into a folder
* remove unnecessary clone
* fix validator_set_count calculation
* introduce ValidatorSetCount
* store ValidatorSetCount
* fmt
* add the benchmark
* fmt
* unflatten slashing
* post-rebase fixes
* remove winners eagerly
* use real slashing weights for westend
* remove bench test suite
* zombinet: modify disputes test to check for an offence report
* zombinet: add a timeout
* add slashing pallet to Rococo
* zombienet: revert back to rococo-local
* fmt
* remove TODOs
* revert some accidental changes
* slashing is submodule of disputes
* Change the log target
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* wrap comments with rustfmt, more docs, constants
* use Defensive trait
* cargo update -p sp-io
* merge offence types, remove rewards for now
* cargo update -p sp-io
* benchmark fixes
* fmt
* unused var
* fix block_author impl
* ressurect RewardValidators trait
* remove outdated comment
* more module docs
* introduce BenchmarkingConfig
* typo fix
* teach spellcheck unapplied
* use Weight::new()
* fix mocking rewards
* use RefTimeWeight
* ".git/.scripts/bench-bot.sh" runtime westend-dev runtime_parachains::disputes::slashing
* refactor maybe_identify_validators
* no more ticket in disguise
* remove outdated comments
* lower against valid to 0.1%
* bump zombienet version for debug
* use from_perthousand
* post-merge fixes
* another day, another Weight changes
* Revert "bump zombienet version for debug"
This reverts commit 0d9978711f8ec9a746a5e1c45e8ffbe7c75e7b5c.
* do not reward block authors
* fix outdated comment
* use Pays from frame_support::dispatch::Pays
* add timeout to is up
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: command-bot <>
Co-authored-by: Javier Viola <javier@parity.io>
Co-authored-by: Javier Viola <pepoviola@gmail.com>
* [Zombienet] add upgrade test (#5970)
* add upgrade test
* fix node names
* changes from feedback
* rename bash script
* fix upgrade node test
* upgrade node test, use env
* bump zombienet version and fix upgrade test
* bump zombienet version
* bump zombienet
* fix raw link for binary
* adjust within time
* Fixes
* Rename Origin (#6020)
* Rename Origin
* fmt
* fixes
* more fixes
* fix
* more fixing
* small fixes
* last touches
* update lockfile for {"substrate"}
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: parity-processbot <>
* [Companion] Get rid of HistoryDepth storage (#5996)
* remove history depth from storage and add it as config for pallet staking
* add migration to v11 for staking pallet
* revert local substrate dependency patch
* remove history depth from storage and add it as config for pallet staking
* add migration to v11 for staking pallet
* revert local substrate dependency patch
* update substrate dependencies
* update cargo lock
* update to latest substrate
* revert all changes to Cargo.lock
* cargo update -p sp-io
* mark migration job as failable
Co-authored-by: kianenigma <kian@parity.io>
* Fixes
* Fixes
* Fixes
* Fixes
* Change visibility of `open_database` for use in cumulus (#6034)
* Make some helper methods public
* Make availability config const.
* Companion for #12283 (Anon -> Pure Proxy) (#6038)
* anon -> pure
* fn pure -> fn create_pure
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Increase BlockHashCount parameter (#6037)
* Some more information on disputes for the guide (#6006)
* Add some notes about treatment of already finalized blocks.
* More info in the guide as discussed with Jakob.
* Remove references to private repo.
* Companion - Independence of Slot-based algorithms from Timestamp (#5997)
* Companion for substrate #12224
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Companion for substrate#11983. (#5992)
* Companion for substrate#11983.
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* [ci] Split gitlab-ci config to separate files (#6031)
* [WIP][ci] Split gitlab-ci config to separate files
* add stage
* move short benches
* rename stage short_benchmark
* include short-benchmarks
* add check
* add test stage
* quickfix check-no-default-features
* add build stage
* add weights and publish
* rename stage
* rename stage
* fix publish miner image
* fix publish miner image
* add dag
* fix image
* start build-short-benchmark with the pipeline
* some more DAGs
* empty line to short-benchmarks
* add change from master
Co-authored-by: parity-processbot <>
* orchestra: hide subsystem cycle warnings by default (#6047)
* Companion for paritytech/substrate#12264 (#5973)
* Companion for paritytech/substrate#12198
* Use `ProtocolName` from sc-network-common
* Update node service
* Revert Cargo.lock changes
* Fix node service test
* cargo-fmt
* disable cancel-pipeline-test-linux-stable to check companion
* update lockfile for {"substrate"}
Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: parity-processbot <>
* paras: unblock offboarding when pvf-check concludes (#6032)
* Unblock offboarding for upgrading paras
* ".git/.scripts/fmt.sh" 1
Co-authored-by: command-bot <>
* [orchestra] fix: require the initialization with `F: FnOnce` to be `Send` (#6051)
* add regression test for missing Send requirement
* fix: require the initialization with `F: FnOnce` to be `Send` as well
If creating intermediate variables of the builder type within
a future, rustc will complain about the future not being send,
while the thing itself isn't even using the closure based field
initialization. Adding an additional bound, resolves this and
pushes the error message "closer" to the user, and out of the
generated code.
* import fixins
* staking miner: CLI make request and connection timeout configurable (#6004)
* staking miner: CLI request and connection timeout
Make it possible to configure the `connection timeout` and `request timeout` via CLI flags.
* cargo fmt
* make spellcheck green again (#6059)
* make spellcheck green again
* remove the comment
* Fix a comment in `provisioner`
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Bump bytes from 1.1.0 to 1.2.1 (#6017)
Bumps [bytes](https://github.com/tokio-rs/bytes) from 1.1.0 to 1.2.1.
- [Release notes](https://github.com/tokio-rs/bytes/releases)
- [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tokio-rs/bytes/compare/v1.1.0...v1.2.1)
---
updated-dependencies:
- dependency-name: bytes
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove executed runtime migrations (nompools MigrateToV3, InitiateNominationPools) (#6056)
* add fast-unstsake pallet to all runtimes (#6050)
* add fast-unstsake pallet to all runtimes
* ".git/.scripts/fmt.sh" 1
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_fast_unstake
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_fast_unstake
* fix up all the weight stuff
* update substrate
* update mistake in kusama
* add stub file
* Update runtime/polkadot/src/lib.rs
Co-authored-by: Nitwit <47109040+BustaNit@users.noreply.github.com>
* Update runtime/westend/src/lib.rs
Co-authored-by: Nitwit <47109040+BustaNit@users.noreply.github.com>
* cargo update -p sp-io
* add signed extension as well
* Revert "add signed extension as well"
This reverts commit deb936fe5a9a13a62d02757045b1dfa40dccb190.
* cargo update -p sp-io
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_fast_unstake
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_fast_unstake
* update sub
* integrate latest substrate changes
* ".git/.scripts/fmt.sh" 1
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_fast_unstake
Co-authored-by: command-bot <>
Co-authored-by: Nitwit <47109040+BustaNit@users.noreply.github.com>
* Update substrate dependencies
* Bump crate versions
* Bump spec_version to 9300
* Rename zombienet extension (#6073)
* Rename extension files and respective entries from '.feature' to '.zndsl'
* Rename zombienet extension for 0001-dispute-valid-block test
* Validate chunks from disk in availability-recovery (#6078)
* Don't use corrupted chunks from disk.
Otherwise we would be going to dispute the candidate and get slashed.
* Add tests
* Demote warning (#6080)
This can happen under heavy load - no value in warning here.
Scenario this happens:
- New slot
- We get asked about what fork to build on
- We start building (create inherent gets called)
- We learn about a better fork (but Babe does not care as it already has a fork)
- 6 seconds passed - New slot
- Babe asks about what for to build on - we answer with the best block we learned about 6 seconds ago (slightly after we got asked the last time)
- We start building (on that old block)
- Milliseconds later we learn about a new block (the one from the slot we are actually in now)
- We kick the old leaf -> create inherent fails
Full discussion: https://github.com/paritytech/substrate/issues/12375
* Bump transaction_version for polkadot
* Bump transaction_version for kusama
* Bump transaction_version for rococo
* Bump transaction_version for westend
* add para_id to fetch_pov logging (#6084)
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Fix: minor typo (#6088)
Fix: minor typo
* Companion for pallet-mmr: generate historical proofs (#6061)
* BEEFY: generate historical proofs
Signed-off-by: Serban Iorga <serban@parity.io>
* cargo update -p sp-io
* Properly set max proof size for runtimes
* Properly set max proof size for mocks
* cargo fmt
* Set appropriate UMP service total proof size weight
* Disable zombienet-tests-parachains-disputes CI
* Add comment explaining weight math
* Use MAX_POV_SIZE for max proof size
* Cast to u64
* Remove comment
Signed-off-by: Serban Iorga <serban@parity.io>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Remove orchestra and metered channel (#6086)
* Use orchestra and metered channel from repo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Update node/subsystem-util/Cargo.toml
Co-authored-by: Andronik <write@reusable.software>
* Update node/subsystem-types/Cargo.toml
Co-authored-by: Andronik <write@reusable.software>
* Update node/metrics/Cargo.toml
Co-authored-by: Andronik <write@reusable.software>
* Update node/overseer/Cargo.toml
Co-authored-by: Andronik <write@reusable.software>
* Update node/overseer/Cargo.toml
Co-authored-by: Andronik <write@reusable.software>
* update cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Andronik <write@reusable.software>
* Companion for substrate#12124: add BEEFY request response protocol (#6035)
* service: add BEEFY request response proto
* update lockfile for {"substrate"}
* update lockfile for substrate
* Governance v2 (Kusama only) (#5205)
* First bits
* Create new origins
* Repot governance configs
* Tests for treasury spends
* Integrate treasury spend threshold origins
* Bump deps
* Add whitelist, configure treasury spend origins
* Add governance curves
* Enable curve's ceil to be configured
* Make compile
* Rest of new governance params
* Build fixes
* Fixes
* Fix warning
* Use new EnsureOrigin::try_successful_origin
* Some repotting
* Add files
* Ready for initial review
* Fixes
* Formatting
* Bump
* rename
* Derive MEL for Origin enum
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_conviction_voting
* Update Cargo.lock
* Update runtime/kusama/src/governance/origins.rs
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
* allow root to demote and promote, fixing benchmarks
* fix whitelist origin benchmarks
* typo
* cargo update -p sp-io
* add second referenda instance to benchmarks
* allow root to act as a 9th dan in track
* feature flag it
* cargo update -p sp-io
* fix merge
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_referenda
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_conviction_voting
* allow root to create auction
* Update mod.rs
* more origin fixes
* root isnt needed actually
* cargo update -p sp-io
* allow root to cancel slash
* initial stuff
* make copy data from kusama
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_referenda
* Update Cargo.lock
* commit new weight files
* more files
* use weight files
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_referenda
* Update Cargo.lock
* Update to latest master
* Formatting
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_ranked_collective
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_conviction_voting
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_conviction_voting
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_whitelist
* Rename Origin -> RuntimeOrigin
This was done in Substrate and is now needed here as well.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Tech Committee can promote to VI Dan
* Update runtime/kusama/src/governance/mod.rs
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
* Formatting
* Update runtime/kusama/src/governance/fellowship.rs
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
* Fixes
* Avoid updating extraneous deps
* Fix broken stuff
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_referenda
* Update runtime/kusama/src/governance/fellowship.rs
* Reorder EitherOf origins
Zero logic change to make the benchmarking work.
It uses the first successful origin which can only promote to rank 6.
By swapping the order we use Root which can always promote.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Revert param change and update doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
* Use active_leaves instead of known_leaves (#6068)
* Use active_leaves for synchronization.
Otherwise on reverts the syncrhonization of create inherent would not
work.
* Add some trace logs.
* Companion for BEEFY: Simplify hashing for pallet-beefy-mmr (#6098)
* beefy-mmr: Simplify hashing
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Keep sessions in window for the full unfinalized chain (#6054)
* Impl dynamic window size. Keep sessions for unfinalized chain
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Stretch also in contructor plus tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* fix approval-voting tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* grunting: dispute coordinator tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Bump lru from 0.7.8 to 0.8.0 (#6060)
* Bump lru from 0.7.8 to 0.8.0
Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases)
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0)
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Change `LruCache` paramerter to `NonZeroUsize`
* Change type of `session_cache_lru_size` to `NonZeroUsize`
* Add expects instead of unwrap
Co-authored-by: Bastian Köcher <info@kchr.de>
* Use match to get rid of expects
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
* Batch vote import in dispute-distribution (#5894)
* Start work on batching in dispute-distribution.
* Guide work.
* More guide changes. Still very much WIP.
* Finish guide changes.
* Clarification
* Adjust argument about slashing.
* WIP: Add constants to receiver.
* Maintain order of disputes.
* dispute-distribuion sender Rate limit.
* Cleanup
* WIP: dispute-distribution receiver.
- [ ] Rate limiting
- [ ] Batching
* WIP: Batching.
* fmt
* Update `PeerQueues` to maintain more invariants.
* WIP: Batching.
* Small cleanup
* Batching logic.
* Some integration work.
* Finish.
Missing: Tests
* Typo.
* Docs.
* Report missing metric.
* Doc pass.
* Tests for waiting_queue.
* Speed up some crypto by 10x.
* Fix redundant import.
* Add some tracing.
* Better sender rate limit
* Some tests.
* Tests
* Add logging to rate limiter
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Update node/network/dispute-distribution/src/receiver/mod.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Review feedback.
* Also log peer in log messages.
* Fix indentation.
* waker -> timer
* Guide improvement.
* Remove obsolete comment.
* waker -> timer
* Fix spell complaints.
* Fix Cargo.lock
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Add unknown words (#6105)
* Buffered connection management for collator-protocol (#6022)
* Extract metrics into a separate module
* Introduce validators buffer
* Integrate buffer into the subsystem
* Only reconnect on new advertisements
* Test
* comma
* doc comment
* Make capacity buffer compile time non-zero
* Add doc comments
* nits
* remove derives
* review
* better naming
* check timeout
* Extract interval stream into lib
* Ensure collator disconnects after timeout
* spellcheck
* rename buf
* Remove double interval
* Add a log on timeout
* Cleanup buffer on timeout
* Properly migrate weights to v2 (#6091)
* Create migration for config pallet
* Use XcmWeight in XCM pallet extrinsics
* Link to PR in doc comment
* cargo fmt
* Fix tests
* Fix tests
* Remove unused import
* Update runtime/parachains/src/configuration/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add missing on_runtime_upgrade implementation
* Use new migration API
* cargo fmt
* Fix log message
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Pass through `runtime-benchmark` feature (#6110)
* Companion for #11649: Bound uses of `Call` (#5729)
* Fixes
* Clear out old weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Resolve merges
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix weight traits
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* polkadot runtime: Clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* rococo runtime: update pallet configs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add preimage migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add all migrations
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Democracy is not on Westend
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* [Migration] Refund stored multisig calls (#6075)
* Add Preimages to referenda config
Needed since Gov V2 just merged.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add multisig migration to Westend+Rococo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix Executive syntax
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Bump Substrate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
* update kvdb & co (#6111)
* toml changes
* REVERTME: patch
* adapt parachains db interface
* fix Cargo.toml patch after master rebase
* fix av-store
* fix chain-selection
* fix parachains-db?
* Revert "fix Cargo.toml patch after master rebase"
This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287.
* Revert "REVERTME: patch"
This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54.
* Use `Ok` imported from prelude
Co-authored-by: Bastian Köcher <info@kchr.de>
* update lockfile for {"substrate"}
* Revert "update lockfile for {"substrate"}"
This reverts commit fdc623de226f7645741b86c4b1a7d030fed2172d.
* cargo update -p sp-io
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: parity-processbot <>
* Skip `unexpected metric type`
* Dump more info for `unexpected metric type`
* Skip `unexpected metric type`
* service: use MmrRootProvider as custom BEEFY payload provider (companion for 12428) (#6112)
* service: use MmrRootProvider as custom BEEFY payload provider
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* update substrate
* Maximum value for `MultiplierUpdate` (#6021)
* update multiplier
* fix
* update lockfile for {"substrate"}
* fmt
* fix typo
Co-authored-by: parity-processbot <>
* Companion for upgrading pin-project (#6118)
* Companion for upgrading pin-project
This will remove some warnings with the latest rustc nightly/stable.
https://github.com/paritytech/substrate/pull/12426
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Some late fixes for XCMv3 (#5237)
* Maximise chances that trapped assets can be reclaimed
* Do origin check as part of ExportMessage for security
* Formatting
* Fixes
* Cleanup export XCM APIs
* Formatting
* Update xcm/src/v3/junctions.rs
* UnpaidExecution instruction and associated barrier.
* Tighten barriers (ClearOrigin/QueryResponse)
* Allow only 1 ClearOrigin instruction in AllowTopLevelPaidExecutionFrom
* Bi-directional teleport accounting
* Revert other fix
* Build fixes]
* Tests build
* Benchmark fixes
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Companion for 12109 (#5929)
* Update following `pallet-vesting` configurable `WithdrawReasons`
* Update lib.rs
* Update lib.rs
* Update lib.rs
* update lockfile for {"substrate"}
* fix warning
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: parity-processbot <>
* Add event to asset claim (#6029)
* Fix flaky test (#6131)
* Split test + decrease test timeout
* fmt
* spellcheck
* ci/guide: install mdbook-graphviz (#6119)
* ci/guide: install mdbook-graphviz
* install graphviz in build-implementers-guide
* Update scripts/ci/gitlab/pipeline/build.yml
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
* Companion for paritytech/substrate#12441 (#6117)
* Companion for paritytech/substrate#12441
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Update tests for Rust 1.64 (#6124)
Co-authored-by: Bastian Köcher <info@kchr.de>
* Companion for #12328 (#6058)
* staking-miner: Adjust `TransactionStatus` update
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
* update lockfile for {"substrate"}
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: parity-processbot <>
* Expose node subcommands in Malus CLI (#6135)
* Expose the full Cli through malus
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* fix lonely test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Update Substrate
* Manual Para Lock (#5451)
* remove para lock check for now
* fmt
* manual para lock
* expose schedule_code_upgrade and set_current_head
* extrinsics and benchmarks
* use zero
* add weights
* fix variable name
* add and fix comments
* fix weights
* add back default lock
Co-authored-by: parity-processbot <>
* refactor grid topology to expose more info to subsystems (#6140)
* refactor grid topology to expose more info to subsystems
* fix grid_topology test
* fix overseer test
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io>
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Andronik <write@reusable.software>
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Andronik <write@reusable.software>
* fix bug in populating topology
* fmt
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io>
Co-authored-by: Andronik <write@reusable.software>
* Malus: add disputed block percentage (#6100)
* Malus: add disputed block percentage
* Bump clap to support value_parser with range
* Add rand crate and use Bernoulli and Distribution
* Add conditional logic based on sampled value from Bernoulli distribution
* Add SuggestGarbageCandidateOptions struct
* Cleanup tests
* * Replace unwrap with expect and meaningful error message
* * Remove Inner
* Remove intercept_outgoing
* * Rename sampled variable
* Move info! logs to include candidate hash of malicious candidate
* * Add percentage option to dispute_ancestor
* * Support static probability for `ReplaceValidationResult` proxy
* Update some comments and docs
* * Add `--percentage` to `back-garbage-candidate` variant
* Rename structs for consistency
* * Add probabilistic behavior to `dispute-ancestor` variant
* Add probabilistic behavior to `back-garbage-candidate` variant
* Rename structs in dispute variant
* * More descriptive comments
* * cargo +nightly fmt --all
* * Move Bernoulli distributrion to ReplaceValidationResult constructor
* Rename random_bool to behave_maliciously
* * Remove dangling comment
* * Consistent log
* * Add logs based on sampled value
* * Cargo +nightly fmt --all
* * Remove unused percentage attributed after moving Bernoulli to constructor
* Squashed commit of the following:
commit e36cc59bfc8338d6fb01f261a243c1f4048773df
Author: Chris Sosnin <48099298+slumber@users.noreply.github.com>
Date: Mon Oct 10 10:06:44 2022 +0400
Fix flaky test (#6131)
* Split test + decrease test timeout
* fmt
* spellcheck
commit f85f96c9d6f4d16bc04f2b3950b091c979adf6d0
Author: girazoki <gorka.irazoki@gmail.com>
Date: Mon Oct 10 06:39:30 2022 +0200
Add event to asset claim (#6029)
commit fb0dd8ebd109c1961d6b52548246908ae6689929
Author: Leszek Wiesner <leszek@jsgenesis.com>
Date: Mon Oct 10 00:23:54 2022 +0200
Companion for 12109 (#5929)
* Update following `pallet-vesting` configurable `WithdrawReasons`
* Update lib.rs
* Update lib.rs
* Update lib.rs
* update lockfile for {"substrate"}
* fix warning
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: parity-processbot <>
commit 1c786b372617f26f5982fadc77269e9d4a7c5da2
Author: Bastian Köcher <info@kchr.de>
Date: Fri Oct 7 13:40:40 2022 +0200
Companion for upgrading pin-project (#6118)
* Companion for upgrading pin-project
This will remove some warnings with the latest rustc nightly/stable.
https://github.com/paritytech/substrate/pull/12426
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
commit 3d6b56342e5e1313685aae6f4e222cbf91ba790f
Author: Sergej Sakac <73715684+Szegoo@users.noreply.github.com>
Date: Thu Oct 6 19:20:58 2022 +0200
Maximum value for `MultiplierUpdate` (#6021)
* update multiplier
* fix
* update lockfile for {"substrate"}
* fmt
* fix typo
Co-authored-by: parity-processbot <>
commit 09f340c928ea324105b39b957dc155cbd29b173d
Author: Adrian Catangiu <adrian@parity.io>
Date: Thu Oct 6 12:58:39 2022 +0300
service: use MmrRootProvider as custom BEEFY payload provider (companion for 12428) (#6112)
* service: use MmrRootProvider as custom BEEFY payload provider
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
commit d12042f1a0a0e34ca274de9035ea35b6c016783f
Author: Branislav Kontur <bkontur@gmail.com>
Date: Thu Oct 6 10:03:34 2022 +0200
Skip `unexpected metric type`
* Dump more info for `unexpected metric type`
* Skip `unexpected metric type`
commit 3646202110b3810027f9d7fd0b45cb1bcb9678f4
Author: Andronik <write@reusable.software>
Date: Thu Oct 6 00:36:51 2022 +0200
update kvdb & co (#6111)
* toml changes
* REVERTME: patch
* adapt parachains db interface
* fix Cargo.toml patch after master rebase
* fix av-store
* fix chain-selection
* fix parachains-db?
* Revert "fix Cargo.toml patch after master rebase"
This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287.
* Revert "REVERTME: patch"
This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54.
* Use `Ok` imported from prelude
Co-authored-by: Bastian Köcher <info@kchr.de>
* update lockfile for {"substrate"}
* Revert "update lockfile for {"substrate"}"
This reverts commit fdc623de226f7645741b86c4b1a7d030fed2172d.
* cargo update -p sp-io
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: parity-processbot <>
commit 7870dafbd88c8a4bdb1d3c3fb94745f0824a8fb6
Author: Gavin Wood <gavin@parity.io>
Date: Wed Oct 5 22:17:59 2022 +0100
Companion for #11649: Bound uses of `Call` (#5729)
* Fixes
* Clear out old weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Resolve merges
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix weight traits
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* polkadot runtime: Clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* rococo runtime: update pallet configs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add preimage migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add all migrations
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Democracy is not on Westend
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* [Migration] Refund stored multisig calls (#6075)
* Add Preimages to referenda config
Needed since Gov V2 just merged.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add multisig migration to Westend+Rococo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix Executive syntax
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Bump Substrate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
commit df4a1c3cd919c727c1c1c3676229193de1134380
Author: Alexander Theißen <alex.theissen@me.com>
Date: Wed Oct 5 15:15:07 2022 +0200
Pass through `runtime-benchmark` feature (#6110)
commit 3eb61f8871220f2a17a98342382270782cdb4b0c
Author: Keith Yeung <kungfukeith11@gmail.com>
Date: Wed Oct 5 17:47:15 2022 +0800
Properly migrate weights to v2 (#6091)
* Create migration for config pallet
* Use XcmWeight in XCM pallet extrinsics
* Link to PR in doc comment
* cargo fmt
* Fix tests
* Fix tests
* Remove unused import
* Update runtime/parachains/src/configuration/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add missing on_runtime_upgrade implementation
* Use new migration API
* cargo fmt
* Fix log message
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
commit edd6499e3220c2a646f2a693108c1084fc6a92ff
Author: Chris Sosnin <48099298+slumber@users.noreply.github.com>
Date: Wed Oct 5 11:48:50 2022 +0400
Buffered connection management for collator-protocol (#6022)
* Extract metrics into a separate module
* Introduce validators buffer
* Integrate buffer into the subsystem
* Only reconnect on new advertisements
* Test
* comma
* doc comment
* Make capacity buffer compile time non-zero
* Add doc comments
* nits
* remove derives
* review
* better naming
* check timeout
* Extract interval stream into lib
* Ensure collator disconnects after timeout
* spellcheck
* rename buf
* Remove double interval
* Add a log on timeout
* Cleanup buffer on timeout
commit c913107a84bb60a70d8d514091631730cbba3cd2
Author: Robert Klotzner <eskimor@users.noreply.github.com>
Date: Tue Oct 4 18:47:52 2022 +0200
Add unknown words (#6105)
commit ce430c22560ddf76188742f870345a9a1eca65dc
Author: Robert Klotzner <eskimor@users.noreply.github.com>
Date: Tue Oct 4 18:02:05 2022 +0200
Batch vote import in dispute-distribution (#5894)
* Start work on batching in dispute-distribution.
* Guide work.
* More guide changes. Still very much WIP.
* Finish guide changes.
* Clarification
* Adjust argument about slashing.
* WIP: Add constants to receiver.
* Maintain order of disputes.
* dispute-distribuion sender Rate limit.
* Cleanup
* WIP: dispute-distribution receiver.
- [ ] Rate limiting
- [ ] Batching
* WIP: Batching.
* fmt
* Update `PeerQueues` to maintain more invariants.
* WIP: Batching.
* Small cleanup
* Batching logic.
* Some integration work.
* Finish.
Missing: Tests
* Typo.
* Docs.
* Report missing metric.
* Doc pass.
* Tests for waiting_queue.
* Speed up some crypto by 10x.
* Fix redundant import.
* Add some tracing.
* Better sender rate limit
* Some tests.
* Tests
* Add logging to rate limiter
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Update node/network/dispute-distribution/src/receiver/mod.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Review feedback.
* Also log peer in log messages.
* Fix indentation.
* waker -> timer
* Guide improvement.
* Remove obsolete comment.
* waker -> timer
* Fix spell complaints.
* Fix Cargo.lock
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
commit efb82ef7b0a0f0a67b43b616471db5921f45a614
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Oct 4 11:28:21 2022 +0000
Bump lru from 0.7.8 to 0.8.0 (#6060)
* Bump lru from 0.7.8 to 0.8.0
Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases)
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0)
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Change `LruCache` paramerter to `NonZeroUsize`
* Change type of `session_cache_lru_size` to `NonZeroUsize`
* Add expects instead of unwrap
Co-authored-by: Bastian Köcher <info@kchr.de>
* Use match to get rid of expects
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
commit 60554e1f2dba9aa1c553e4bdbd15c5c99936c56a
Author: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Date: Tue Oct 4 13:36:42 2022 +0300
Keep sessions in window for the full unfinalized chain (#6054)
* Impl dynamic window size. Keep sessions for unfinalized chain
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Stretch also in contructor plus tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* fix approval-voting tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* grunting: dispute coordinator tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
commit 4ddf0ffe5b6d75149016bed74e2d587acf011cb9
Author: Serban Iorga <serban@parity.io>
Date: Tue Oct 4 12:25:48 2022 +0300
Companion for BEEFY: Simplify hashing for pallet-beefy-mmr (#6098)
* beefy-mmr: Simplify hashing
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Revert "Squashed commit of the following:"
This reverts commit 5001fa5d1dcd366029d156f81c40b99ca29d8f77.
* Companion for BEEFY: Simplify hashing for pallet-beefy-mmr (#6098)
* beefy-mmr: Simplify hashing
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Keep sessions in window for the full unfinalized chain (#6054)
* Impl dynamic window size. Keep sessions for unfinalized chain
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Stretch also in contructor plus tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* fix approval-voting tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* grunting: dispute coordinator tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Bump lru from 0.7.8 to 0.8.0 (#6060)
* Bump lru from 0.7.8 to 0.8.0
Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases)
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0)
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Change `LruCache` paramerter to `NonZeroUsize`
* Change type of `session_cache_lru_size` to `NonZeroUsize`
* Add expects instead of unwrap
Co-authored-by: Bastian Köcher <info@kchr.de>
* Use match to get rid of expects
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
* Batch vote import in dispute-distribution (#5894)
* Start work on batching in dispute-distribution.
* Guide work.
* More guide changes. Still very much WIP.
* Finish guide changes.
* Clarification
* Adjust argument about slashing.
* WIP: Add constants to receiver.
* Maintain order of disputes.
* dispute-distribuion sender Rate limit.
* Cleanup
* WIP: dispute-distribution receiver.
- [ ] Rate limiting
- [ ] Batching
* WIP: Batching.
* fmt
* Update `PeerQueues` to maintain more invariants.
* WIP: Batching.
* Small cleanup
* Batching logic.
* Some integration work.
* Finish.
Missing: Tests
* Typo.
* Docs.
* Report missing metric.
* Doc pass.
* Tests for waiting_queue.
* Speed up some crypto by 10x.
* Fix redundant import.
* Add some tracing.
* Better sender rate limit
* Some tests.
* Tests
* Add logging to rate limiter
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Update node/network/dispute-distribution/src/receiver/mod.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Review feedback.
* Also log peer in log messages.
* Fix indentation.
* waker -> timer
* Guide improvement.
* Remove obsolete comment.
* waker -> timer
* Fix spell complaints.
* Fix Cargo.lock
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Add unknown words (#6105)
* Buffered connection management for collator-protocol (#6022)
* Extract metrics into a separate module
* Introduce validators buffer
* Integrate buffer into the subsystem
* Only reconnect on new a…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3211
Previously it was only enabled on Versi