Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights #5988

Merged
merged 6 commits into from
Sep 12, 2022
Merged

update weights #5988

merged 6 commits into from
Sep 12, 2022

Conversation

coderobe
Copy link
Contributor

@coderobe coderobe commented Sep 9, 2022

🏋️‍♀️

@coderobe coderobe added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 9, 2022
Weight::from_ref_time(1_256_000 as u64)
// Standard Error: 42_000
.saturating_add(Weight::from_ref_time(26_925_000 as u64).saturating_mul(s as u64))
Weight::from_ref_time(11_217_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x10 jump

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Looks like an asymptotic decrease actually.

Weight::from_ref_time(921_000 as u64)
// Standard Error: 35_000
.saturating_add(Weight::from_ref_time(21_922_000 as u64).saturating_mul(s as u64))
Weight::from_ref_time(15_840_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x15 jump

Weight::from_ref_time(0 as u64)
// Standard Error: 62_000
.saturating_add(Weight::from_ref_time(24_926_000 as u64).saturating_mul(s as u64))
Weight::from_ref_time(10_761_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump from 0 -> 10_761_000

Weight::from_ref_time(0 as u64)
// Standard Error: 40_000
.saturating_add(Weight::from_ref_time(7_752_000 as u64).saturating_mul(v as u64))
Weight::from_ref_time(310_326_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump from 0 -> 310_326_000

Weight::from_ref_time(0 as u64)
// Standard Error: 43_000
.saturating_add(Weight::from_ref_time(51_696_000 as u64).saturating_mul(n as u64))
Weight::from_ref_time(15_720_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump from 0 -> 15_720_000

Weight::from_ref_time(0 as u64)
// Standard Error: 28_000
.saturating_add(Weight::from_ref_time(29_706_000 as u64).saturating_mul(b as u64))
Weight::from_ref_time(13_392_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump from 0 -> 13_392_000

// Standard Error: 0
.saturating_add(Weight::from_ref_time(165_000 as u64).saturating_mul(m as u64))
.saturating_add(Weight::from_ref_time(25_000 as u64).saturating_mul(m as u64))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x7 jump down

// Standard Error: 0
.saturating_add(Weight::from_ref_time(163_000 as u64).saturating_mul(m as u64))
.saturating_add(Weight::from_ref_time(27_000 as u64).saturating_mul(m as u64))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x7 jump down

Weight::from_ref_time(125_000 as u64)
// Standard Error: 37_000
.saturating_add(Weight::from_ref_time(23_169_000 as u64).saturating_mul(s as u64))
Weight::from_ref_time(13_757_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant jump 125_000 -> 13_757_000

Weight::from_ref_time(0 as u64)
// Standard Error: 37_000
.saturating_add(Weight::from_ref_time(7_545_000 as u64).saturating_mul(v as u64))
Weight::from_ref_time(105_025_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant jump 0 -> 105_025_000

Weight::from_ref_time(0 as u64)
// Standard Error: 41_000
.saturating_add(Weight::from_ref_time(49_451_000 as u64).saturating_mul(n as u64))
Weight::from_ref_time(21_631_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump from 0 -> 21_631_000

Weight::from_ref_time(0 as u64)
// Standard Error: 25_000
.saturating_add(Weight::from_ref_time(51_756_000 as u64).saturating_mul(n as u64))
Weight::from_ref_time(18_891_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump 0 -> 18_891_000

@@ -109,11 +109,11 @@ impl<T: frame_system::Config> pallet_election_provider_multi_phase::WeightInfo f
/// The range of component `a` is `[500, 800]`.
/// The range of component `d` is `[200, 400]`.
fn elect_queued(a: u32, d: u32, ) -> Weight {
Weight::from_ref_time(9_172_000 as u64)
Weight::from_ref_time(0 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant change

Weight::from_ref_time(0 as u64)
// Standard Error: 14_000
.saturating_add(Weight::from_ref_time(18_621_000 as u64).saturating_mul(k as u64))
Weight::from_ref_time(19_773_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump from 0 -> 19_773_000

Weight::from_ref_time(0 as u64)
// Standard Error: 28_000
.saturating_add(Weight::from_ref_time(48_794_000 as u64).saturating_mul(n as u64))
Weight::from_ref_time(18_538_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jump from 0 -> 18_538_000

@chevdor
Copy link
Contributor

chevdor commented Sep 9, 2022

I am surprised not to see Kusama in here

@ggwpez
Copy link
Member

ggwpez commented Sep 10, 2022

I am surprised not to see Kusama in here

The benchmarking has some shortcomings for very short functions, like Remark. Remark has an empty function body and can therefore mess with the results. paritytech/substrate#11806 should improve precision.

@coderobe coderobe merged commit 94078b4 into release-v0.9.29 Sep 12, 2022
@coderobe coderobe deleted the coderobe/weights-29 branch September 12, 2022 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants