Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF preparation: do not conflate errors #6384

Merged
merged 9 commits into from
Dec 20, 2022
Merged

PVF preparation: do not conflate errors #6384

merged 9 commits into from
Dec 20, 2022

Commits on Dec 2, 2022

  1. PVF preparation: do not conflate errors 

    + Adds some more granularity to the prepare errors.
+ Better distinguish whether errors occur on the host side or the worker.
+ Do not kill the worker if the error happened on the host side.
+ Do not retry preparation if the error was `Panic`.
+ Removes unnecessary indirection with `Selected` type.
    @mrcnski
    mrcnski committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    21fb0e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Add missing docs, resolve TODOs

    @mrcnski
    mrcnski committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    9d4681a View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Address review comments and remove TODOs

    @mrcnski
    mrcnski committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    79a76d1 View commit details
    Browse the repository at this point in the history

  2. Fix error in CI

    @mrcnski
    mrcnski committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    c410d1c View commit details
    Browse the repository at this point in the history

  3. Undo unnecessary change

    @mrcnski
    mrcnski committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    7ea847e View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Merge branch 'master' into m-cat/pvf-preparation-do-not-conflate-errors

    @mrcnski
    mrcnski committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    eed5063 View commit details
    Browse the repository at this point in the history

  2. Update couple of comments

    @mrcnski
    mrcnski committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    39628df View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Don't return error for stream shutdown

    @mrcnski
    mrcnski committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    36a8a5f View commit details
    Browse the repository at this point in the history

  2. Update node/core/pvf/src/worker_common.rs

    @mrcnski
    mrcnski authored Dec 19, 2022
    Configuration menu
    Copy the full SHA
    d88190d View commit details
    Browse the repository at this point in the history