Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

av-store: skip processing finalized blocks while major syncing #6691

Merged
merged 1 commit into from
Feb 9, 2023
Merged

av-store: skip processing finalized blocks while major syncing #6691

merged 1 commit into from
Feb 9, 2023

Conversation

ordian
Copy link
Member

@ordian ordian commented Feb 8, 2023

Might help with #6656.

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. T0-node This PR/Issue is related to the topic “node”. labels Feb 8, 2023
@ordian ordian mentioned this pull request Feb 8, 2023
Closed
bkchr
bkchr approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the overseer itself should not send the signal when major sync is active? Or there could be some extra field in the signal telling you if the signal was generated while doing a major sync.

@sandreim
Copy link
Contributor

sandreim commented Feb 9, 2023

Maybe the overseer itself should not send the signal when major sync is active? Or there could be some extra field in the signal telling you if the signal was generated while doing a major sync.

Adding the major sync flag to the signal makes sense to me.

@ordian ordian linked an issue Feb 9, 2023 that may be closed by this pull request
Subsystem (av-store) stalled while major syncing #6656
Closed
@ordian ordian mentioned this pull request Feb 9, 2023
Closed
@ordian
Copy link
Member Author

ordian commented Feb 9, 2023

submitted #6694 as a follow-up

@ordian
Copy link
Member Author

ordian commented Feb 9, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 7a8cae1 into master Feb 9, 2023
@paritytech-processbot paritytech-processbot bot deleted the ao-sync-oracle-av-store branch February 9, 2023 13:22
@jasl
Copy link
Contributor

jasl commented Feb 9, 2023

Could this be backported to 0.9.38 branch?

@tdimitrov tdimitrov mentioned this pull request Feb 16, 2023
Merged
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
@librelois librelois mentioned this pull request Apr 6, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandreim sandreim sandreim approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subsystem (av-store) stalled while major syncing
4 participants
@ordian @sandreim @jasl @bkchr