Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adding Dispute Participation Metrics #6838

Merged
merged 15 commits into from
Mar 11, 2023
Merged

Adding Dispute Participation Metrics #6838

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
107f971
Added participation and queue sizes metrics
BradleyOlson64 Mar 7, 2023
a8186fc
First draft of all metric code
BradleyOlson64 Mar 7, 2023
b6cb2c7
Tests pass
BradleyOlson64 Mar 7, 2023
faa7eb5
Merge branch 'master' of https://github.com/paritytech/polkadot into …
BradleyOlson64 Mar 7, 2023
bc7049e
Changed Metrics to field on participation + queues
BradleyOlson64 Mar 8, 2023
7b0bfc0
fmt
BradleyOlson64 Mar 8, 2023
56e7723
Improving naming
BradleyOlson64 Mar 9, 2023
4185d4d
Refactor, placing timer in ParticipationRequest
BradleyOlson64 Mar 9, 2023
20ceda9
fmt
BradleyOlson64 Mar 9, 2023
02e5608
Final cleanup
BradleyOlson64 Mar 10, 2023
6444e6d
Merge branch 'master' of https://github.com/paritytech/polkadot into …
BradleyOlson64 Mar 10, 2023
008063f
Revert "Final cleanup"
BradleyOlson64 Mar 10, 2023
207bb2a
Changing metric names
BradleyOlson64 Mar 10, 2023
3fcb639
Implementing Eq only for unit tests
BradleyOlson64 Mar 10, 2023
ef611aa
fmt
BradleyOlson64 Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions node/core/dispute-coordinator/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ struct MetricsInner {
/// requested dispute is complete.
participation_pipeline_durations: prometheus::Histogram,
/// Size of participation priority queue
priority_queue_size: prometheus::Gauge<prometheus::U64>,
participation_priority_queue_size: prometheus::Gauge<prometheus::U64>,
/// Size of participation best effort queue
best_effort_queue_size: prometheus::Gauge<prometheus::U64>,
participation_best_effort_queue_size: prometheus::Gauge<prometheus::U64>,
}

/// Candidate validation metrics.
Expand Down Expand Up @@ -126,14 +126,14 @@ impl Metrics {
/// Set the priority_queue_size metric
pub fn report_priority_queue_size(&self, size: u64) {
if let Some(metrics) = &self.0 {
metrics.priority_queue_size.set(size);
metrics.participation_priority_queue_size.set(size);
}
}

/// Set the best_effort_queue_size metric
pub fn report_best_effort_queue_size(&self, size: u64) {
if let Some(metrics) = &self.0 {
metrics.best_effort_queue_size.set(size);
metrics.participation_best_effort_queue_size.set(size);
}
}
}
Expand Down Expand Up @@ -221,12 +221,12 @@ impl metrics::Metrics for Metrics {
)?,
registry,
)?,
priority_queue_size: prometheus::register(
participation_priority_queue_size: prometheus::register(
prometheus::Gauge::new("polkadot_parachain_dispute_priority_queue_size",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should the metric names be updated to match the new variable names? e.g. "polkadot_parachain_dispute_participation_priority_queue_size"

"Number of disputes waiting for local participation in the priority queue.")?,
registry,
)?,
best_effort_queue_size: prometheus::register(
participation_best_effort_queue_size: prometheus::register(
prometheus::Gauge::new("polkadot_parachain_dispute_best_effort_queue_size",
"Number of disputes waiting for local participation in the best effort queue.")?,
registry,
Expand Down