Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Onchain scraper in dispute-coordinator will scrape SCRAPED_FINALIZED_BLOCKS_COUNT blocks before finality #7013

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Onchain scraper in dispute-coordinator will scrape SCRAPED_FINALIZED_BLOCKS_COUNT blocks before finality #7013

merged 3 commits into from
Apr 7, 2023

Conversation

tdimitrov
Copy link
Contributor

Fixes #7009

@tdimitrov
Onchain scraper in dispute-coordinator will scrape `SCRAPED_FINALIZ…
1525ede 
…ED_BLOCKS_COUNT` blocks before finality

The purpose is to make the availability of a `CandidateReceipt` for finalized candidates more likely.

For details see:  #7009
@tdimitrov tdimitrov added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. labels Apr 6, 2023
@tdimitrov
Copy link
Contributor Author

I've tested it on Versi - there is an improvement. After deploying it I don't see "Cannot obtain relay parent without CandidateReceipt".

@tdimitrov tdimitrov mentioned this pull request Apr 6, 2023
Open
ordian
ordian approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit and a question about off-by-one, looks good otherwise

node/core/dispute-coordinator/src/scraping/mod.rs Outdated Show resolved Hide resolved
node/core/dispute-coordinator/src/scraping/mod.rs Outdated Show resolved Hide resolved
eskimor
eskimor reviewed Apr 7, 2023
View reviewed changes
node/core/dispute-coordinator/src/scraping/mod.rs Outdated
/// Initialize this value with `DISPUTE_CANDIDATE_LIFETIME_AFTER_FINALIZATION`
/// If `SCRAPED_FINALIZED_BLOCKS_COUNT` > `DISPUTE_CANDIDATE_LIFETIME_AFTER_FINALIZATION`
/// scraper's job will be undone on pruning.
pub(crate) const SCRAPED_FINALIZED_BLOCKS_COUNT: NonZeroU32 =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why these two values would ever need to differ. I would have just used DISPUTE_CANDIDATE_LIFETIME_AFTER_FINALIZATION directly, just changing docs. Name is actually still fine, I think.

@tdimitrov
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 7b6ea48 into master Apr 7, 2023
@paritytech-processbot paritytech-processbot bot deleted the tsv-disp-coord-scraping branch April 7, 2023 20:34
ordian added a commit that referenced this pull request Apr 11, 2023
@ordian
Merge branch 'master' into ao-polkadot-enable-dispute-slashing
de707de 
* master: (28 commits)
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  Drop timers for new requests of active participations (#6974)
  Use `SIGTERM` instead of `SIGKILL` on PVF worker version mismatch (#6981)
  Tighter bound on asset types teleported so that weight is cheaper (#6980)
  staking miner: less aggresive submissions (#6978)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
4f660d1 
* master: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…
89a1a16 
…slashing-client

* ao-past-session-slashing-runtime: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
jasl added a commit to Phala-Network/khala-parachain that referenced this pull request Apr 27, 2023
@jasl
backport paritytech/polkadot#7013
a5441fa
jasl added a commit to Phala-Network/khala-parachain that referenced this pull request Apr 27, 2023
@jasl
Backport polkadot 7013 (#281)
c37925e 
* backport paritytech/polkadot#7013

* Bump node version to v0.1.24-3
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eskimor eskimor eskimor left review comments

@sandreim sandreim sandreim approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dispute-coordinator sometimes fails importing dispute votes on startup due to missing CandidateReceipt
4 participants
@tdimitrov @eskimor @ordian @sandreim