-
Notifications
You must be signed in to change notification settings - Fork 1.6k
paras: dismiss pvf_checking_enabled
configuration
#7138
paras: dismiss pvf_checking_enabled
configuration
#7138
Conversation
8ea6667
to
a50ca39
Compare
aa599df
to
09927f9
Compare
bot bench $ runtime polkadot runtime_parachains::paras |
@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766578 was started for your command Comment |
@slumber Command |
bot bench $ runtime kusama runtime_parachains::paras |
@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766810 was started for your command Comment |
@slumber Command |
bot bench $ runtime rococo runtime_parachains::paras |
@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2767605 was started for your command Comment |
@slumber Command |
bot bench $ runtime westend runtime_parachains::paras |
@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2769086 was started for your command Comment |
@slumber Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super familiar with the runtime-side so I read this for education. Maybe ignore my approval but I think it looks good.
Nice! Great work, only two small remarks. The weight explosion is interesting, do you have any explanation? |
bot merge |
Error: Statuses failed for 8bc1b33 |
bot merge |
Waiting for commit status. |
Part of #3211
Node side doesn't require any changes. Prechecking subsystem is conditionally disabled if the node is not authority, disregarding the runtime configuration. So I suggest we leave it as is.
Removing
pvf_checking_enabled
from host configuration requires storage migration. This can be done in the same PR or in a follow-up, depending on how quickly this gets merged. For now it's simply ignored.