-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add a new template to show the list of host functions #7158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
@koute your MR actually modified a host function, not added a new one, or?
So we should probably change the description of the label and section eventually.
@ggwpez @koute expained actually quite nicely in his PR. This situation occurs quite often: a new host function is added but not in use yet. Still it is better to raise awareness that a new host function showed up. If users upgrade now, it will be all good if they don't later when it is really needed. We could add a special mention as free note but is it worth it ? |
I think it is fine, my concern was about the formulation: "one new host function". |
Exactly this is correct! It is then required by a human to "fix" this afterwards in the release notes. |
I am editing this for the upcoming release and indeed I should change the wording in the template. The number we inject in the template is not the number of host functions as you pointed out @ggwpez but the number of PRs related to host functions. The E3 label has been mostly used to introduce new host functions (active or not) but the labels do not carry the information about the number of host fn affected. I will rephrase that part. |
Yes. Would be nice to have a dedicated label for this. Maybe something like this:
|
I am totally fine with that @koute. This kind of granularity allows being super accurate when listing/grouping those PRs. For now, I will fix the templates with the labels we currently have. @koute I opened a separate issue to keep track of your suggestion. |
bot rebase |
Rebased |
bot merge |
Waiting for commit status. |
Before
After