Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump clap to 4.2.5 #7160

Merged
merged 1 commit into from
May 2, 2023
Merged

Bump clap to 4.2.5 #7160

merged 1 commit into from
May 2, 2023

Conversation

altaua
Copy link
Contributor

@altaua altaua commented May 2, 2023 •
edited
Loading

cumulus companion: paritytech/cumulus#2505

@altaua altaua added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. E2-dependencies Pull requests that update a dependency file. labels May 2, 2023
@altaua altaua self-assigned this May 2, 2023
@bkchr bkchr requested a review from skunert May 2, 2023 13:25
@altaua altaua mentioned this pull request May 2, 2023
Merged
coderobe
coderobe approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@coderobe coderobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i recall a previous clap bump subtly breaking behaviour that was being relied on - this should maybe be smoke-tested locally for the usual use cases?

@altaua altaua merged commit 689623c into master May 2, 2023
@altaua altaua deleted the mira/clap branch May 2, 2023 17:55
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Head SHA changed from 8aee93a to cc28275

@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lexnv lexnv lexnv approved these changes

@coderobe coderobe coderobe approved these changes

@bkchr bkchr bkchr approved these changes

@skunert skunert skunert approved these changes

Assignees

@altaua altaua

Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. E2-dependencies Pull requests that update a dependency file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@altaua @skunert @bkchr @coderobe @lexnv