Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[xcm] Extend haul_blob with Channel + include NetworkId to channel id (origin/(network, destination)) #7244

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[xcm] Extend haul_blob with Channel + include NetworkId to channel id (origin/(network, destination)) #7244

wants to merge 6 commits into from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented May 17, 2023 •
edited
Loading

Useful for paritytech/parity-bridges-common#2451

  • Add cumulus companion (if this approach is approved)

Open questions:

  • Shouldnt BridgeMessage be versioned? e.g. 
    VersionedBridgeMessage {
     V3(v3::BridgeMessage)
}

@bkontur bkontur requested a review from gavofyork May 17, 2023 14:10
@bkontur bkontur added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. T6-XCM This PR/Issue is related to XCM. labels May 17, 2023
@bkontur bkontur mentioned this pull request May 18, 2023
Open
6 tasks
@bkontur
Copy link
Contributor Author

bkontur commented May 30, 2023

bot bench $ runtime rococo runtime_parachains::paras_inherent

@command-bot
Copy link

command-bot bot commented May 30, 2023 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2915460 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 26-36f7568b-b413-4036-8138-162a43235dbc to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 30, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2915460 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2915460/artifacts/download.

@bkontur bkontur mentioned this pull request Aug 25, 2023
Closed
@franciscoaguirre franciscoaguirre mentioned this pull request Jul 31, 2023
Open
KiChjang
KiChjang reviewed Aug 3, 2023
View reviewed changes
xcm/xcm-executor/src/traits/export.rs
/// An identifier for a channel.
pub type Channel = u32;

/// Generates channel identifier for `origin/(network, destination)` combination to ensure using separated lanes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destination network or source network?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang left review comments

@gavofyork gavofyork Awaiting requested review from gavofyork

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkontur @KiChjang