Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[frame/im-online] remove network state from heartbeats #7309

Conversation

melekes
Copy link
Contributor

@melekes melekes commented May 30, 2023

@melekes melekes added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. B1-note_worthy Changes should be noted in the release notes labels May 31, 2023
@melekes melekes changed the title [frame/im-online] remove external_addresses from heartbeat [frame/im-online] remove network state from heartbeat May 31, 2023
@melekes melekes changed the title [frame/im-online] remove network state from heartbeat [frame/im-online] remove network state from heartbeats May 31, 2023
@melekes melekes added the T1-runtime This PR/Issue is related to the topic “runtime”. label May 31, 2023
@paritytech-ci paritytech-ci requested a review from a team May 31, 2023 07:24
@melekes
Copy link
Contributor Author

melekes commented May 31, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@melekes melekes requested a review from a team June 2, 2023 10:52
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melekes
Copy link
Contributor Author

melekes commented Jun 15, 2023

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: cd "/storage/repositories/polkadot" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

@melekes melekes force-pushed the anton/7181-remove-external-addresses-from-heartbeats branch from 6c9077a to a40edc9 Compare June 15, 2023 07:20
@melekes
Copy link
Contributor Author

melekes commented Jun 15, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 0e614b0 into master Jun 15, 2023
@paritytech-processbot paritytech-processbot bot deleted the anton/7181-remove-external-addresses-from-heartbeats branch June 15, 2023 10:25
@bkchr
Copy link
Member

bkchr commented Jun 15, 2023

@melekes this pull requested missed to add the im_online::v1::Migration to the list of the UnreleasedMigrations in Polkadot/Kusama.

@liamaharon liamaharon mentioned this pull request Jun 20, 2023
1 task
bkchr pushed a commit that referenced this pull request Jun 25, 2023
* add pallet_im_online::migration to Unreleased migrations

refs #7309 (comment)

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
ggwpez pushed a commit to ggwpez/runtimes that referenced this pull request Jul 10, 2023
* add pallet_im_online::migration to Unreleased migrations

refs paritytech/polkadot#7309 (comment)

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
ggwpez pushed a commit to ggwpez/runtimes that referenced this pull request Jul 13, 2023
* add pallet_im_online::migration to Unreleased migrations

refs paritytech/polkadot#7309 (comment)

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants