Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix migrations #7340

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix migrations #7340

merged 1 commit into from
Jun 8, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jun 7, 2023

Okay this was stupid 🤦

To get the CI check green here we will need to decrease the max_code_size to 3 MiB like in #7108. Otherwise the consistency check fails. Maybe it wont go green until paritytech/substrate#14311, not sure.

Okay this was stupid 🤦

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@@ -352,13 +361,13 @@ executor_params : Default::default(),
}
};

let v4 = V4ActiveConfig::<T>::get()
let v4 = v4::ActiveConfig::<T>::get()
.defensive_proof("Could not decode old config")
.unwrap_or_default();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unwrap_or_default did not help any, since the following V5ActiveConfig::<T>::set ignore it.

@ggwpez ggwpez added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”. B1-note_worthy Changes should be noted in the release notes labels Jun 7, 2023
@coderobe coderobe mentioned this pull request Jun 7, 2023
14 tasks
@ggwpez
Copy link
Member Author

ggwpez commented Jun 8, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 4a40eba into master Jun 8, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-fix-migrations branch June 8, 2023 08:51
chevdor pushed a commit that referenced this pull request Jun 9, 2023
Okay this was stupid 🤦

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@chevdor chevdor mentioned this pull request Jun 9, 2023
coderobe pushed a commit that referenced this pull request Jun 12, 2023
Okay this was stupid 🤦

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants