This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Vstam1/nonfungibles adapter v2 #7344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsidorenko
reviewed
Jul 27, 2023
KiChjang
reviewed
Aug 3, 2023
liamaharon
reviewed
Aug 4, 2023
liamaharon
reviewed
Aug 7, 2023
vstam1
added
A0-please_review
KiChjang
reviewed
Aug 8, 2023
KiChjang
approved these changes
Aug 17, 2023
| Assets: nonfungibles_v2::Transfer<AccountId>, | ||
| Matcher: MatchesNonFungibles<Assets::CollectionId, Assets::ItemId>, | ||
| AccountIdConverter: ConvertLocation<AccountId>, | ||
| AccountId: Clone, // can't get away without it since Currency is generic over it. |
There was a problem hiding this comment.
Suggested change
| AccountId: Clone, // can't get away without it since Currency is generic over it. | |
| AccountId: Clone, // can't get away without it since `nonfungibles_v2` is generic over it. |
| Assets: nonfungibles_v2::Mutate<AccountId, ItemConfig>, | ||
| Matcher: MatchesNonFungibles<Assets::CollectionId, Assets::ItemId>, | ||
| AccountIdConverter: ConvertLocation<AccountId>, | ||
| AccountId: Clone + Eq, // can't get away without it since Currency is generic over it. |
There was a problem hiding this comment.
Suggested change
| AccountId: Clone + Eq, // can't get away without it since Currency is generic over it. | |
| AccountId: Clone + Eq, // can't get away without it since `nonfungibles_v2` is generic over it. |
| Assets: nonfungibles_v2::Mutate<AccountId, ItemConfig>, | ||
| Matcher: MatchesNonFungibles<Assets::CollectionId, Assets::ItemId>, | ||
| AccountIdConverter: ConvertLocation<AccountId>, | ||
| AccountId: Clone + Eq, // can't get away without it since Currency is generic over it. |
There was a problem hiding this comment.
Suggested change
| AccountId: Clone + Eq, // can't get away without it since Currency is generic over it. | |
| AccountId: Clone + Eq, // can't get away without it since `nonfungibles_v2` is generic over it. |
| Assets: nonfungibles_v2::Mutate<AccountId, ItemConfig> + nonfungibles_v2::Transfer<AccountId>, | ||
| Matcher: MatchesNonFungibles<Assets::CollectionId, Assets::ItemId>, | ||
| AccountIdConverter: ConvertLocation<AccountId>, | ||
| AccountId: Clone + Eq, // can't get away without it since Currency is generic over it. |
There was a problem hiding this comment.
Suggested change
| AccountId: Clone + Eq, // can't get away without it since Currency is generic over it. | |
| AccountId: Clone + Eq, // can't get away without it since `nonfungibles_v2` is generic over it. |
Comment on lines
+432
to
+440
| impl Incrementable for MultiLocationCollectionId { | ||
| fn increment(&self) -> Option<Self> { | ||
| None | ||
| } | ||
|
|
||
| fn initial_value() -> Option<Self> { | ||
| None | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it necessary to implement this? Aren't we going to be forcing the collection id of collections identified by MultiLocations?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces the
NonFungiblesV2Adapteras a new type for the XCM executor's AssetTransactor type, designed to work with the NFTs pallet. This Pr is a PoC to investigate how the NFTs pallet could work with XCM.Introduces:
NonFungiblesV2AdapterMultiLocationCollectionId: Wrapper for MultiLocation that implements theIncrementabletrait. The trait implementation allow the NFT's pallet CollectionId type to be a wrapped MultiLocation.xcm-simulatorparachain runtime.