Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Clear Existing HRMP Channel Request When Force Opening #7389

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Clear Existing HRMP Channel Request When Force Opening #7389

merged 5 commits into from
Jun 21, 2023

Conversation

joepetrowski
Copy link
Contributor

Quite often a parachain makes a channel request to a system parachain, followed by a governance proposal that fails because the request already exists. Since we are using "force", this removes the common error case by clearing an existing request.

@joepetrowski joepetrowski added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”. B1-note_worthy Changes should be noted in the release notes labels Jun 17, 2023
bkchr
bkchr approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% correct solution would work with weight refunding, but not sure it is wort the complexity given that this is not called that often.

runtime/parachains/src/hrmp/benchmarking.rs Outdated Show resolved Hide resolved
bkchr
bkchr approved these changes Jun 19, 2023
View reviewed changes
runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved
runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from ggwpez June 19, 2023 20:55
joepetrowski and others added 2 commits June 20, 2023 06:35
@joepetrowski @bkchr
Apply suggestions from code review
1752df3 
Co-authored-by: Bastian Köcher <git@kchr.de>
@joepetrowski
fix
f8e1178
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3041571

@joepetrowski
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ac65f3b into master Jun 21, 2023
@paritytech-processbot paritytech-processbot bot deleted the joe-clear-hrmp-request-on-force branch June 21, 2023 14:57
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joepetrowski @paritytech-cicd-pr @bkchr @ggwpez