Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create OR rule #12

Closed
Bullrich opened this issue Jul 6, 2023 · 0 comments · Fixed by #48
Closed

Create OR rule #12

Bullrich opened this issue Jul 6, 2023 · 0 comments · Fixed by #48
Assignees
@Bullrich
Milestone
Project launch

Comments

@Bullrich
Copy link
Contributor

Bullrich commented Jul 6, 2023

Reference: https://github.com/paritytech/pr-custom-review#or-rule-syntax-
@Bullrich Bullrich added this to the Project launch milestone Jul 6, 2023
@Bullrich Bullrich self-assigned this Jul 6, 2023
@Bullrich Bullrich linked a pull request Aug 11, 2023 that will close this issue
Created 'OR' rule #48
Merged
@Bullrich Bullrich mentioned this issue Aug 11, 2023
Merged
Bullrich added a commit that referenced this issue Aug 14, 2023
@Bullrich @rzadp
Created 'OR' rule (#48)
8f9e8a7 
New feature: **The _OR_ rule**

# List of changes
- Created `OR` rule
  - This resolves #12
- The OR rule verifies that *one* of the conditions have been fulfilled.
- When a condition was fulfilled, it continues the loop to the next rule
- When the `OR` rule fails, it shows all the users it needs a review but
it only shows the amount of missing reviews using the sub condition with
the minimum amount of reviews needed.
    - Created lots of test.
- This are mainly a copy and modification of `AND` as they share logic
and structure.

---------

Co-authored-by: Przemek Rzad <roopert7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging a pull request may close this issue.

Created 'OR' rule paritytech/review-bot
1 participant
@Bullrich