Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status check sometimes does not appear #54

Closed
Bullrich opened this issue Aug 23, 2023 · 0 comments · Fixed by #63
Closed

Status check sometimes does not appear #54

Bullrich opened this issue Aug 23, 2023 · 0 comments · Fixed by #63
Assignees
@Bullrich
Labels
bug Something isn't working
Milestone
Project launch

Comments

@Bullrich
Copy link
Contributor

For some reason on some cases the status check does not appear. It exists, but it doesn't appear on the required checks.

This may be a limitation of using GitHub actions for the check.

Could be related to https://github.com/orgs/community/discussions/24616

Related task is: #33
@Bullrich Bullrich added the bug Something isn't working label Aug 23, 2023
@Bullrich Bullrich added this to the Project launch milestone Aug 23, 2023
@Bullrich Bullrich self-assigned this Aug 23, 2023
@Bullrich Bullrich mentioned this issue Aug 28, 2023
Closed
@Bullrich Bullrich linked a pull request Aug 29, 2023 that will close this issue
Status check fix #63
Merged
@Bullrich Bullrich mentioned this issue Aug 29, 2023
Merged
Bullrich added a commit that referenced this issue Aug 30, 2023
@Bullrich
Status check fix (#63)
665fa80 
Fixes #54

Abstracted the code to generate check runs to its own class.

In theory, it can share the same key as the `Teams` class, but we want
to keep it separated so the `Team` class can be hot swapped for a chain
data class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
bug Something isn't working
Projects
None yet
Milestone
Project launch
Development

Successfully merging a pull request may close this issue.

Status check fix paritytech/review-bot
1 participant
@Bullrich