Migrated fellows to use People chain and PAPI
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/polkadot/fellows.ts
Outdated
Comment on lines
42
to
77
| const getGhHandle = async (address: SS58String): Promise<string | undefined> => { | ||
| logger.debug(`Fetching identity of '${address}'`); | ||
| const identityOf = await peopleApi.query.Identity.IdentityOf.getValue(address); | ||
|
|
||
| if (identityOf) { | ||
| const [identity] = identityOf; | ||
| const github = identity.info.github.value; | ||
|
|
||
| if (!github) { | ||
| logger.debug(`'${address}' does not have an additional field named 'github'`); | ||
| return; | ||
| } | ||
|
|
||
| const handle = github.asText().replace("@", "") as string; | ||
|
|
||
| if (handle) { | ||
| logger.info(`Found github handle for '${address}': '${handle}'`); | ||
| } else { | ||
| this.logger.debug("No super identity found. Skipping"); | ||
| logger.debug(`'${address}' does not have a GitHub handle`); | ||
| return; | ||
| } | ||
| continue; | ||
| return handle; | ||
| } | ||
|
|
||
| const [fellowData] = identityQuery.toHuman() as [Record<string, unknown>, unknown]; | ||
| logger.debug(`Identity of '${address}' is null. Checking for super identity`); | ||
|
|
||
| // @ts-ignore | ||
| const additional = fellowData.info?.additional as [{ Raw: string }, { Raw: string }][] | undefined; | ||
| const superIdentityAddress = (await peopleApi.query.Identity.SuperOf.getValue(address))?.[0]; | ||
|
|
||
| // If it does not have additional data (GitHub handle goes here) we ignore it | ||
| if (!additional || additional.length < 1) { | ||
| this.logger.debug("Additional data is null. Skipping"); | ||
| continue; | ||
| if (superIdentityAddress) { | ||
| logger.debug(`'${address}' has a super identity: '${superIdentityAddress}'. Fetching that identity`); | ||
| return await getGhHandle(superIdentityAddress); | ||
| } else { | ||
| logger.debug(`No superidentity for ${address} found.`); | ||
| return undefined; | ||
| } | ||
|
|
||
| for (const additionalData of additional) { | ||
| const [key, value] = additionalData; | ||
| // We verify that they have an additional data of the key "github" | ||
| // If it has a handle defined, we push it into the array | ||
| if (key?.Raw && key?.Raw === "github" && value?.Raw && value?.Raw.length > 0) { | ||
| this.logger.debug(`Found handles: '${value.Raw}'`); | ||
| // We add it to the array and remove the @ if they add it to the handle | ||
| users.set(value.Raw.replace("@", ""), fellow.rank); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Could we move this function outside please? It got too nested so I didn't get where the function ends at first 😅
mutantcornholio
approved these changes
Jul 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People Chain..papidirectory).nccis not bundling together so we need to keep thenode_modules(like@polkadot-api/metadata-compatibility)2.6.0