-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration file handling #17
Conversation
@mutantcornholio could you please help me with the linting? I'm having the following issue and I don't know how to properly fix it:
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start to me.
The compiler is complaining that the tests are not inside the src directory. That is frustrating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Added handling of the configuration file.
Closes #5
This adds the field to the action file to look for the configuration file so we can set a different field, and defaults to
.github/review.yml
.Created the basic type for the configuration file.
This adds the:
preventReviewRequests
prevent-review-requests
topreventReviewRequests
Created tests to evaluate all this types and validations.
Also created JOI validations for the configuration object. I have discovered that it still won't be enough in the case that a regex is invalid, so I added #16 to have visibility of it.
Miscelanious
Created the PullRequestApi class
This class will use the default github secret generated by the action. We will have a second class to handle the teams.
It is mocked in the tests.
Created the Runner class
This will be the main class that will combine all the other classes and APIs (basically the
core.ts
file but with proper abstractions).