Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed user's review not being taken in order #39

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Fixed user's review not being taken in order #39

merged 4 commits into from
Aug 3, 2023

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Aug 3, 2023

The system currently searches for approved reviews, but if a user approves a review, and then they reject the review, only the approval review takes this change into consideration.

This solves that problem and fixes #38

@Bullrich Bullrich self-assigned this Aug 3, 2023
@Bullrich Bullrich requested a review from a team as a code owner August 3, 2023 13:16
Copy link
Contributor

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this shit

@Bullrich Bullrich merged commit 88feb92 into main Aug 3, 2023
@Bullrich Bullrich deleted the review-fix branch August 3, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple reviews from same user collide
2 participants