updated repo to use team github app #41
Conversation
The step array was wrong. Now it will look in the correct place. Also, it will not run outside of PRs
| # !This must always point to main. | ||
| # Change it for the PRs but remember to change it back | ||
| - uses: paritytech/review-bot@main | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| team-token: ${{ secrets.TEST_TEAM_TOKEN }} | ||
| team-token: ${{ steps.team_token.outputs.token }} |
There was a problem hiding this comment.
Does it make sense to use its own (review bot) app? i am afraid how we gonna find out where the team app's id/key being used outside of list-team-members ?
There was a problem hiding this comment.
It could make sense, but because it is being used for exactly the same requirements than list-team-members I thought that we could recycle that app.
For the new org we will need to create a new app anyways.
There was a problem hiding this comment.
then if this app dies or something else changes, would be useful to have the list of things app needs to access read/write. Just to recover quickly and for sure
There was a problem hiding this comment.
Yeah, I'll be adding it to the README eventually.
It just need read: org permissions. Nothing else.
You can find a comment telling that here
Now that https://github.com/paritytech/internal_it/issues/205 has been completed, this change removes my personal access token and replaces it for the GitHub App.