Implement request reviewers on itself #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzadp
approved these changes
Oct 31, 2023
README.md
Outdated
| @@ -433,6 +439,10 @@ It also has any other field from the [`basic rule`](#basic-rule) (with the excep | |||
| - **Optional**: Defaults to `false`. | |||
| - **minRank**: Must be a number. | |||
| - **Required** | |||
|
|
|||
| ##### Note | |||
| The fellows rule will never request reviewers, even if `request-reviewers` rule is enabled. | |||
There was a problem hiding this comment.
I feel like adding a reason for this would be good.
I understand it's because it would result in too many reviewers requested for lower levels of fellows.
I think it should be put down in writing for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three changes:
repo-tokenfield to use the GitHub app which now haspull-requestwrite permissions.request-reviewers(won't trigger on this PR until it is merged).