Update rve toolchain in unified image #615
Conversation
pgherveou
force-pushed
the
pg/update-riscv-unified-image
branch
from
3b73d47
to
49eda0c
Compare
| @@ -281,6 +275,18 @@ RUN cargo install --git https://github.com/paritytech/ink-waterfall.git csv-comp | |||
| # parity-scale-codec | |||
| RUN cargo +nightly-${RUST_NIGHTLY_VERSION} install grcov rust-covfix xargo dylint-link | |||
|
|
|||
| # Install rve-nightly-2023-04-05 | |||
|
|
|||
| RUN cargo install cargo-web wasm-pack cargo-deny cargo-hack \ | ||
| mdbook mdbook-mermaid mdbook-linkcheck mdbook-graphviz mdbook-admonish mdbook-last-changed | ||
|
|
||
| RUN cargo install cargo-nextest --locked | ||
| RUN cargo install cargo-spellcheck cargo-nextest --locked | ||
|
|
There was a problem hiding this comment.
It is good practise to avoid the multipliction of layers in a docker image.
So instead of:
RUN cargo install foo
RUN cargo install bar
the following is preferable:
RUN cargo install foo bar
If you prefer a mutiline option to keep things clear, you may use:
RUN cargo install \
foo bar \
baz
There was a problem hiding this comment.
just changed what was breaking, I think we should move all these install to use --locked.
Otherwise this could break for future version as I discovered here.
|
|
||
| RUN wget https://github.com/paritytech/rustc-rv32e-toolchain/releases/download/rust-rve-nightly-2023-04-05-x86_64-unknown-linux-gnu/rust-rve-nightly-2023-04-05-x86_64-unknown-linux-gnu.tar.zst && \ | ||
| tar --zstd -xf rust-rve-nightly-2023-04-05-x86_64-unknown-linux-gnu.tar.zst && \ | ||
| mv tmp/rve-nightly /usr/local/rustup/toolchains && \ |
There was a problem hiding this comment.
It would be safer to use /tmp instead of tmp
There was a problem hiding this comment.
it's ./tmp here that is extracted from the tarball
| mdbook mdbook-mermaid mdbook-linkcheck mdbook-graphviz mdbook-admonish mdbook-last-changed | ||
|
|
||
| RUN cargo install cargo-nextest --locked | ||
| RUN cargo install cargo-spellcheck cargo-nextest --locked | ||
|
|
||
| # generic ci | diener 0.4.6 | NOTE: before upgrading please test new version with companion build, example can be found here: https://github.com/paritytech/substrate/pull/12710 | ||
| RUN cargo install diener --version 0.4.6 |
There was a problem hiding this comment.
it would be good to pack all the cargo install together if possible
There was a problem hiding this comment.
Not sure why we don't do --locked for all of them. I assumed it was to save some downloads and re-use as many common crates as possible
|
@chevdor is it okay that openssl will be upgraded in ci image to 3.1.4 version? |
|
@alvicsam I don't know which version is in the image right now, assuming the new version does not involve breaking changes, it will be fine. I am not aware of anything depending on a specific version. We will see that in CI way before we need to use it in the release anyway. So it is safe and wise to try updating to a current version. |
Update the unified-ci script with the latest version of the risc-v toolchain and openssl to version 3.1.4
cc https://github.com/paritytech/ci_cd/issues/910