This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
optimize ws-health-exporter #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BulatSaif <bulat@parity.io>
PierreBesson
approved these changes
Mar 6, 2024
kogeler
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: paritytech/helm-charts#330
When
ws-health-exporteris used as a sidecar in Kubernetes, it adds a delay to the start and stop of the pod.During startup, the node needs a couple of seconds to reach 10 peers. If we have 2 peers, it should be enough.
During shutdown, the container ignores the signal from Kubernetes, causing it to hang for another 30 seconds while the main container is dead.