Adding cargo-edit and gh to ci-unified
#651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutantcornholio
changed the title
mutantcornholio
force-pushed
the
yuri/add-cargo-edit
branch
from
7f83c80
to
4585f97
Compare
mutantcornholio
force-pushed
the
yuri/add-cargo-edit
branch
from
dd86718
to
4585f97
Compare
This allows Cargo.toml manipulation in CI, primarily, versioning. Will be useful for publishing crates, based on tags.
This currently fails to compile with `duplicate lang item in crate `std` (which `memchr` depends on): `panic_impl`.` We're also downloading a binary of this package just a bit earlier in Dockerfile.
mutantcornholio
force-pushed
the
yuri/add-cargo-edit
branch
2 times, most recently
from
5d25e34
to
d8925b9
Compare
mutantcornholio
changed the title
cargo-edit and gh to ci-unified
alvicsam
reviewed
Aug 15, 2024
dockerfiles/ci-unified/Dockerfile
Outdated
| @@ -83,6 +83,9 @@ RUN pip install yq | |||
|
|
|||
| ### generic ci #### | |||
|
|
|||
| RUN wget https://github.com/cli/cli/releases/download/v2.54.0/gh_2.54.0_linux_amd64.deb && \ | |||
There was a problem hiding this comment.
I think it worth moving the 2.54.0 version to an ARG
mutantcornholio
force-pushed
the
yuri/add-cargo-edit
branch
from
d8925b9
to
c57442a
Compare
alvicsam
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Cargo.toml manipulation in CI, primarily, versioning.
Will be useful for publishing crates, based on tags.