Fix issue with lifetime elision #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, according to rust-lang/rust#63376 , the compiler used to accept the current function signature of `drain_extensions()` by mistake, the compiler will soon fix this (after the above PR lands), and after that the current code won't compile. This PR fixes the code. Please note that the latest published version soketto-0.2.2 contains this error too.
|
Thank you! |
twittner
added a commit
to twittner/substrate
that referenced
this pull request
Aug 21, 2019
This version fixes an issue with lifetime elision which causes compilation to fail on recent rustc versions (e.g. 1.39.0-nightly (bea0372a1 2019-08-20)). See paritytech/soketto#1 for more information.
gavofyork
pushed a commit
to paritytech/substrate
that referenced
this pull request
Aug 21, 2019
This version fixes an issue with lifetime elision which causes compilation to fail on recent rustc versions (e.g. 1.39.0-nightly (bea0372a1 2019-08-20)). See paritytech/soketto#1 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, according to rust-lang/rust#63376 , the compiler used to accept the current function signature of
drain_extensions()by mistake. The compiler will soon fix this (when the above said PR lands), and after that the current code won't compile.This PR fixes the code. Please note that the latest published version soketto-0.2.2 contains this error too.