Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix benchmark workflow, move docs to gh-pages #1552

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Nov 20, 2024

PR fixes script for benchmarks and adds workflow for automatic publishing docs.

@TarikGul @Imod7 docs workflow now works only if files in the docs folder has changed. Is it ok?

cc https://github.com/paritytech/ci_cd/issues/1086

@alvicsam alvicsam marked this pull request as ready for review November 20, 2024 11:27
@alvicsam alvicsam requested review from a team as code owners November 20, 2024 11:27
@Imod7
Copy link
Contributor

Imod7 commented Nov 20, 2024

Thank you @alvicsam for this follow up PR.

Regarding the docs workflow, we need it to run when :

  • the src/openapi-v1.yaml is updated/changed
  • and as soon as a PR that changes this file is merged in master branch

There is also the case where we update the docs folder by changing the package.json file so in this case we do not need the docs to be published again. It does not do any harm if we do publish but it is not necessary.

@alvicsam
Copy link
Contributor Author

@Imod7

Both conditions are now in the workflow

Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the last changes! It looks great!
I have one last question : Since in the gh-pages branch under dev/bench we have a data.js, I would expect that these graphs would be populated already but they are not. Is that expected ?

EDIT : Question already answered int he chat: I will check again when the benchmarks workflow runs. Thank you!

@alvicsam alvicsam merged commit 226f656 into master Nov 20, 2024
12 checks passed
@alvicsam alvicsam deleted the as-fix-bench branch November 20, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants