-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix benchmark workflow, move docs to gh-pages #1552
Conversation
8753715
to
04a3932
Compare
Thank you @alvicsam for this follow up PR. Regarding the docs workflow, we need it to run when :
There is also the case where we update the |
Both conditions are now in the workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the last changes! It looks great!
I have one last question : Since in the gh-pages
branch under dev/bench
we have a data.js
, I would expect that these graphs would be populated already but they are not. Is that expected ?
EDIT : Question already answered int he chat: I will check again when the benchmarks workflow runs. Thank you!
PR fixes script for benchmarks and adds workflow for automatic publishing docs.
@TarikGul @Imod7 docs workflow now works only if files in the
docs
folder has changed. Is it ok?cc https://github.com/paritytech/ci_cd/issues/1086