Update frame/sudo/src/extension.rs

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
paritytech · Nov 3, 2022 · edb408e · edb408e
1 parent e2f955b
commit edb408e
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/frame/sudo/src/extension.rs b/frame/sudo/src/extension.rs
@@ -86,19 +86,13 @@ where
 		info: &DispatchInfoOf<Self::Call>,
 		_len: usize,
 	) -> TransactionValidity {
-		let sudo_key: T::AccountId = match <Pallet<T>>::key() {
-			Some(account) => account,
-			None => return Err(UnknownTransaction::CannotLookup.into()),
-		};
+		let sudo_key: T::AccountId = <Pallet<T>>::key().ok_or(UnknownTransaction::CannotLookup)?;
+		ensure!(*who == sudo_key, InvalidTransaction::BadSigner);
 
-		if *who == sudo_key {
-			Ok(ValidTransaction {
-				priority: info.weight.ref_time() as TransactionPriority,
-				..Default::default()
-			})
-		} else {
-			Err(InvalidTransaction::BadSigner.into())
-		}
+		Ok(ValidTransaction {
+			priority: info.weight.ref_time() as TransactionPriority,
+			..Default::default()
+		})
 	}
 
 	fn pre_dispatch(