Calling proxy doesn't remove announcement (#13267)

* Calling proxy doesn't remove announcement * Update frame/proxy/src/tests.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * fmt --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
paritytech · Feb 5, 2023 · f88a55e · f88a55e
1 parent 0d47b62
commit f88a55e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/frame/proxy/src/lib.rs b/frame/proxy/src/lib.rs
@@ -183,8 +183,6 @@ pub mod pallet {
 		/// Dispatch the given `call` from an account that the sender is authorised for through
 		/// `add_proxy`.
 		///
-		/// Removes any corresponding announcement(s).
-		///
 		/// The dispatch origin for this call must be _Signed_.
 		///
 		/// Parameters:

diff --git a/frame/proxy/src/tests.rs b/frame/proxy/src/tests.rs
@@ -288,6 +288,23 @@ fn announcer_must_be_proxy() {
 	});
 }
 
+#[test]
+fn calling_proxy_doesnt_remove_announcement() {
+	new_test_ext().execute_with(|| {
+		assert_ok!(Proxy::add_proxy(RuntimeOrigin::signed(1), 2, ProxyType::Any, 0));
+
+		let call = Box::new(call_transfer(6, 1));
+		let call_hash = BlakeTwo256::hash_of(&call);
+
+		assert_ok!(Proxy::announce(RuntimeOrigin::signed(2), 1, call_hash));
+		assert_ok!(Proxy::proxy(RuntimeOrigin::signed(2), 1, None, call));
+
+		// The announcement is not removed by calling proxy.
+		let announcements = Announcements::<Test>::get(2);
+		assert_eq!(announcements.0, vec![Announcement { real: 1, call_hash, height: 1 }]);
+	});
+}
+
 #[test]
 fn delayed_requires_pre_announcement() {
 	new_test_ext().execute_with(|| {