You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
kianenigma opened this issue
Sep 4, 2022
· 1 comment
· Fixed by #12327
Labels
Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coderZ6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Recently, we added some events to some of the tests in pallet-election-provider-multi-phase.
This is generally a good patterns and I want all tests to basically finish with an assertion over the events that got fired during the tests. The author should verify that the events are sensible to the best of their abilities.
Lastly, in some experimental work, I've replaced all of the roll_to(x) to roll_to_eventName. We want all tests to use this pattern as well, for less breaking changes.
For example, almost all of the cases where we roll_to(15), we want to roll_to_unsigned().
while !matches!(MultiBlock::current_phase(),Phase::Unsigned(_)){
roll_next()
}
}
/// proceed block number to whenever the signed phase is open (`Phase::Signed(_)`).
pubfnroll_to_signed_open(){
while !matches!(MultiBlock::current_phase(),Phase::Signed){
roll_next();
}
}
The text was updated successfully, but these errors were encountered:
kianenigma
added
Z6-mentor
An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Z1-easy
Can be fixed primarily by duplicating and adapting code by an intermediate coder
labels
Sep 4, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coderZ6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Recently, we added some events to some of the tests in
pallet-election-provider-multi-phase
.This is generally a good patterns and I want all tests to basically finish with an assertion over the events that got fired during the tests. The author should verify that the events are sensible to the best of their abilities.
Here is another example: #11343
Lastly, in some experimental work, I've replaced all of the roll_to(
x
) toroll_to_eventName
. We want all tests to use this pattern as well, for less breaking changes.For example, almost all of the cases where we
roll_to(15)
, we want toroll_to_unsigned()
.substrate/frame/election-provider-multi-block/src/mock/mod.rs
Lines 548 to 559 in d7e45e5
The text was updated successfully, but these errors were encountered: