Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

frame_support::pallet_prelude: Add scale_info::TypeInfo #10221

Merged
merged 1 commit into from
Nov 9, 2021
Merged

frame_support::pallet_prelude: Add scale_info::TypeInfo #10221

merged 1 commit into from
Nov 9, 2021

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Nov 9, 2021

Signed-off-by: koushiro koushiro.cqx@gmail.com

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@KiChjang KiChjang added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Nov 9, 2021
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay, but let's hear what other reviewers have to say about changes like this.

@xlc
Copy link
Contributor

xlc commented Nov 9, 2021

Decode and Encode are included so I think it makes perfect sense to include TypeInfo as well.

@bkchr bkchr merged commit fae2ac6 into paritytech:master Nov 9, 2021
@koushiro koushiro deleted the typeinfo-pallet-prelude branch November 9, 2021 12:01
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants