Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remote Keystore based on OPTEE #10423

Closed
wants to merge 45 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2021

This PR adds support to the substrate node for a secret management solution using OPTEE that holds the secrets for the node in an HSM separate from the machine running the node.

Please contact us here or via email at hello@zondax.ch (or other established channels where available) for any clarification.


There are currently 2 blockers with merging/rebasing with master:

  • Rust version requirement
    The hsm image is pinned with Rust 1.54 (which doesn't understand 2021 edition)
  • Unreleased crates (new versions)
    The project relies on a few crates from the substrate primitives and core, such as sp-keystore, most to conform to the traits required for a keystore, but as the development branches make use of unreleased crates based on path dependencies, it becomes difficult to patch these due to how cargo handles dependency resolution (basically it first attempts to look for the crate version specified on the manifest, and if not found it errors, without resolving to patches) (for a recently merged branch see teekeystore-merged

/cc @jleni @neithanmo

✄ -----------------------------------------------------------------------------

Thank you for your Pull Request! 🙏

Before you submit, please check that:

  • Description: You added a brief description of the PR, e.g.:
    • What does it do?
    • What important points should reviewers know?
    • Is there something left for follow-up PRs?
  • Labels: You labeled the PR appropriately if you have permissions to do so:
    • A* for PR status (one required)
    • B* for changelog (one required)
    • C* for release notes (exactly one required)
    • D* for various implications/requirements
    • Github project assignment
  • Related Issues: You mentioned a related issue if this PR is related to it, e.g. Fixes #228 or Related #1337.
  • 2 Reviewers: You asked at least two reviewers to review. If you aren't sure, start with GH suggestions.
  • Style Guide: Your PR adheres to the style guide
    • In particular, mind the maximal line length of 100 (120 in exceptional circumstances).
    • There is no commented code checked in unless necessary.
    • Any panickers in the runtime have a proof or were removed.
  • Runtime Version: You bumped the runtime version if there are breaking changes in the runtime.
  • Docs: You updated any rustdocs which may need to change.
  • Polkadot Companion: Has the PR altered the external API or interfaces used by Polkadot?
    • If so, do you have the corresponding Polkadot PR ready?
    • Optionally: Do you have a corresponding Cumulus PR?

Refer to the contributing guide for details.

After you've read this notice feel free to remove it.
Thank you!

✄ -----------------------------------------------------------------------------

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Dec 6, 2021

User @becominginsane, please sign the CLA here.

@ghost
Copy link
Author

ghost commented Dec 6, 2021

Notice hasn't been removed because we lack the labels and we are not able to add them (or at least not me)

deps: remove tee-keystore branch
deps: remove tee-keystore local patch
feat(make): skip wasm build
@stale
Copy link

stale bot commented Jan 15, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 15, 2022
feat: add demo script for complete demo
fix: remove unnecessary mut
@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 25, 2022
@stale
Copy link

stale bot commented Feb 24, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Feb 24, 2022
@stale stale bot closed this Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants