Make Polkadot use the Substrate traity libraries #105

gavofyork · 2018-04-02T10:49:13Z

No description provided.

rphmeier · 2018-04-04T16:26:24Z

polkadot/runtime/src/lib.rs

-		pub fn signature(&self) -> &Signature {
-			&self.0.signature
-		}
+mod tests {


maybe reinstate these

meh - they're just serialisation tests; not sure they really belong here (i.e. rather than in generic) but didn't want to throw away the code.

some of the tests are for things like transactions coming after timestamp, etc. I would prefer to remove anything rather than comment it out because it's in the git history anyway.

rphmeier · 2018-04-04T16:26:32Z

polkadot/runtime/src/lib.rs

+	}
+}
+
+pub type Header = generic::Header<BlockNumber, Hash, Vec<u8>>;


seems like changes from the end of the last PR were lost (docs and presumably all the other small cleanups)

may have got clobbered. my god i hate that git can't support merging squashed commits.

rphmeier · 2018-04-04T18:17:44Z

All the other changes in the recent cleanup commits were lost as well -- maybe they can be replayed on top.

gavofyork · 2018-04-04T18:40:21Z

those were not lost - they were never there. i had previously split out the runtime.

gavofyork · 2018-04-04T18:40:45Z

(i already replayed them - they're already in there)

rphmeier · 2018-04-05T10:51:31Z

substrate/runtime/primitives/src/traits.rs

@@ -35,7 +35,7 @@ pub trait Verify {
 }

 /// Ed25519 signature verify.
-#[derive(Eq, PartialEq, Clone)]
+#[derive(Eq, PartialEq, Clone, Default)]
 #[cfg_attr(feature = "std", derive(Debug, Serialize))]
 pub struct Ed25519Signature(H512);


this isn't a trait, and makes the type alias Signature which references this confusing

it's not meant to be a trait. not sure which usage of Signature you mean, but if it's in a more general context than ed25519 or Polkadot than it should be removed in favour of this. (i would note that it's perfectly reasonable for polkadot::Signature to mean Ed25519Signature.)

I mean that it's in the traits module and type polkadot::Signature = traits::Ed25519Signature is misleading.

rphmeier · 2018-04-05T10:52:34Z

substrate/runtime/primitives/src/traits.rs

+	fn is_empty(&self) -> bool;
+}
+
+impl<T: Default + PartialEq> MaybeEmpty for T {


this blanket impl is overbroad. The Default trait doesn't imply emptiness at all. Are there some types in particular we want this for?

yes - specifically for PublicAux, for which AccountId is used in production environments (but tests use u64 hence this generalisation). it should eventually be refactored (as i note somewhere near) so that it's actually only implemented for Option<AccountId> and u64, but for now, it gets the job done without requiring substantial changes in how PublicAux is dispatched

paritytech/polkadot#111

rphmeier · 2018-04-05T10:57:54Z

polkadot/transaction-pool/src/lib.rs

+		if unchecked.extrinsics[0].is_signed() {
+			return Err(unchecked);
+		}
+		if let Call::Timestamp(TimestampCall::set(_)) = unchecked.extrinsics[0].extrinsic.function {} else {


could rewrite this as

if let Call::Timestamp(...) = ... { Ok(...) } else { Err(...) }

would work right now, but not in general since we'd expect more validity tests to be added here.

that's fine. the if let X {} else { ... } is unidiomatic so I'd prefer a match statement.

rphmeier · 2018-04-05T11:00:44Z

polkadot/transaction-pool/src/lib.rs

+
+	/// Create a new block, skipping any high-level well-formedness checks. WARNING: This could
+	/// result in internal functions panicking if the block is, in fact, not well-formed.
+	pub fn force_from(known_good: Block) -> Self {


the main problem with this is that the errors occur in such a way that it's difficult to track down the point at which the programmer error was actually made.

We're changing types like HeaderView which are supposed to take only trusted data in Parity-Ethereum to solve a similar problem by having the function take the file name and line number and having the view carry those around to incorporate in panic messages, so we get the cause instead of just the symptom. We also provide a macro which invokes this constructor using the file!() and line!() macros internally.

I would be in support of a similar change being done here (it only adds a pointer and u32 to the size of the structure)

rphmeier · 2018-04-05T11:01:42Z

polkadot/transaction-pool/src/lib.rs

+		if let Call::Timestamp(TimestampCall::set(t)) = self.0.extrinsics[0].extrinsic.function {
+			t
+		} else {
+			unreachable!();


definitely not unreachable

rphmeier · 2018-04-05T11:04:13Z

polkadot/runtime/src/parachains.rs

+		let mut roles_gua = roles_val.clone();
+
+		let h = <system::Module<T>>::random_seed();
+		let mut seed = Vec::<u8>::new().and(&h).and(b"validator_role_pairs").blake2_256();


h.to_vec().and(...) seems cleaner

* Update to substrate alpha.7 * Remove gas limit from contracts put code * Rename SystemEvent::ReapedAccount to KilledAccount * Log debug event received before attempting to decode * Temporary registration of Balance type before paritytech#102 merged * Show contract test errors, increase instantiate gas_limit

gavofyork added A3-in_progress Pull request is in progress. No review needed at this stage. A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 2, 2018

gavofyork added 3 commits April 4, 2018 17:50

Initial stuff.

f02c34f

Various fixes.

80c90a8

Fix tests.

6b7b944

gavofyork force-pushed the gav-merge-runtime branch from aa041e1 to 6b7b944 Compare April 4, 2018 16:18

gavofyork added 2 commits April 4, 2018 18:21

Fix another test

34b6530

Fix another test.

dd3c9cc

rphmeier reviewed Apr 4, 2018

View reviewed changes

Docs in polkadot runtime.

37c32a3

gavofyork added 12 commits April 4, 2018 21:07

Fix up ser/de tests.

54de947

Update god keys

0ebe496

Syntax

861c1dc

Fix

1abb6a5

Merge remote-tracking branch 'origin/master' into gav-merge-runtime

c305299

Merge remote-tracking branch 'origin/master' into gav-merge-runtime

e75e47c

Permissions on init.sh

f8af345

Port-over the whitespace from @rphmeier

9d39263

Rename

0cb074f

Merge branch 'master' into gav-merge-runtime

2f50576

Merge branch 'master' into gav-merge-runtime

6c1149c

Fix typo.

dcefdc4

rphmeier reviewed Apr 5, 2018

View reviewed changes

gavofyork mentioned this pull request Apr 5, 2018

Transaction queue integration + submission RPC #99

Merged

Fix grumbles.

cd135ab

rphmeier mentioned this pull request Apr 5, 2018

Runtime: Fix broken blanket implementation of MaybeEmpty in Runtime primitives #111

Closed

gavofyork added 2 commits April 5, 2018 16:41

Make more idiomatic.

dc91a44

Move Ed25519Signature out of traits.

45c8ffc

rphmeier approved these changes Apr 5, 2018

View reviewed changes

rphmeier added A8-looksgood and removed A0-please_review Pull request needs code review. labels Apr 5, 2018

rphmeier merged commit ef9a426 into master Apr 5, 2018

rphmeier deleted the gav-merge-runtime branch April 5, 2018 15:13

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020

Add comment about guarantees (paritytech#105)

81f446a

JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021

Register parachain script moving to docker (paritytech#105)

a46ae64

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021

update substrate to real rc3 version(current is rc2) (paritytech#105)

be12db2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Polkadot use the Substrate traity libraries #105

Make Polkadot use the Substrate traity libraries #105

gavofyork commented Apr 2, 2018

rphmeier Apr 4, 2018

gavofyork Apr 4, 2018

rphmeier Apr 4, 2018

rphmeier Apr 4, 2018 •

edited

Loading

gavofyork Apr 4, 2018

rphmeier commented Apr 4, 2018

gavofyork commented Apr 4, 2018

gavofyork commented Apr 4, 2018

rphmeier Apr 5, 2018

gavofyork Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018

gavofyork Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018

rphmeier Apr 5, 2018

gavofyork Apr 5, 2018

rphmeier Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018

rphmeier Apr 5, 2018

Make Polkadot use the Substrate traity libraries #105

Make Polkadot use the Substrate traity libraries #105

Conversation

gavofyork commented Apr 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier Apr 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier commented Apr 4, 2018

gavofyork commented Apr 4, 2018

gavofyork commented Apr 4, 2018

Choose a reason for hiding this comment

gavofyork Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

rphmeier Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

rphmeier Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier Apr 4, 2018 •

edited

Loading

gavofyork Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018 •

edited

Loading

gavofyork Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018 •

edited

Loading

rphmeier Apr 5, 2018 •

edited

Loading