This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Allow the treasury to have a maximum bound on the bond #10689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
Pull request needs code review.
B7-runtimenoteworthy
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Jan 18, 2022
CC @rrtti |
KiChjang
reviewed
Jan 18, 2022
kianenigma
approved these changes
Jan 18, 2022
@@ -199,6 +199,7 @@ As mentioned above, Bounties, Tips and Lottery have been extracted out of treasu | |||
type OnSlash = (); | |||
type ProposalBond = ProposalBond; | |||
type ProposalBondMinimum = ProposalBondMinimum; | |||
type ProposalBondMaximum = (); | |||
type SpendPeriod = SpendPeriod; | |||
type Burn = Burn; | |||
+ type BurnDestination = (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an actual +
sign in the text?
shawntabrizi
approved these changes
Jan 18, 2022
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
26 tasks
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polkadot companion: paritytech/polkadot#4739
Allow the treasury to have an upper limit to the size of bond required for proposals.