Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Updating shell.nix nightly #11266

Merged
merged 7 commits into from
Apr 27, 2022
Merged

Conversation

gilescope
Copy link
Contributor

The 2022-02-10 nightly can't build a dep we're pulling in:

There's a sig that returns impl IntoIterator<Item = (&'static str, OsString)> and an Option is being returned as the concrete implementation of the iterator but it's incorrectly not allowing a ? in the method.

There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method.
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Apr 22, 2022
@gilescope gilescope added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 22, 2022
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work for me…

$ nix-shell --run "cargo check --workspace --all-targets --all-features"

error[E0428]: the name `can_build_child_tree` is defined multiple times
    --> utils/frame/remote-externalities/src/lib.rs:1195:8
     |
1102 |     async fn can_build_child_tree() {
     |           ------------------------- previous definition of the value `can_build_child_tree` here
...
1195 |     async fn can_build_child_tree() {
     |           ^^^^^^^^^^^^^^^^^^^^^^^^^ `can_build_child_tree` redefined here
     |
     = note: `can_build_child_tree` must be defined only once in the value namespace of this module

    Checking beefy-gadget v4.0.0-dev (/home/vados/substrate/client/beefy)
warning: unused import: `std::env`
  --> frame/support/test/tests/construct_runtime_ui.rs:18:5
   |
18 | use std::env;
   |     ^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `frame-support-test` (test "construct_runtime_ui") generated 1 warning
For more information about this error, try `rustc --explain E0428`.
error: could not compile `remote-externalities` due to previous error
warning: build failed, waiting for other jobs to finish...

A CI check would help to spot these regressions.

@gilescope
Copy link
Contributor Author

Good spot. That test is unlikely to pass on anyone else's machine than his. I don't think he intended to commit that version. I've removed it.

@gilescope gilescope requested a review from ggwpez April 26, 2022 06:33
@ggwpez
Copy link
Member

ggwpez commented Apr 26, 2022

It somehow still fails… I will open a CI ticket, maybe we can get a check?

error: environment variable `SNAP` not defined
    --> frame/state-trie-migration/src/lib.rs:1587:36
     |
1587 |             OfflineConfig { state_snapshot: env!("SNAP").to_owned().into() },
     |                                             ^^^^^^^^^^^^
     |
     = note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: environment variable `WS_API` not defined
    --> frame/state-trie-migration/src/lib.rs:1589:16
     |
1589 |                 transport: std::env!("WS_API").to_owned().into(),
     |                            ^^^^^^^^^^^^^^^^^^^
     |
     = note: this error originates in the macro `std::env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: environment variable `SNAP` not defined
    --> frame/state-trie-migration/src/lib.rs:1590:26
     |
1590 |                 state_snapshot: Some(env!("SNAP").to_owned().into()),
     |                                      ^^^^^^^^^^^^
     |
     = note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

@gilescope gilescope requested a review from a team as a code owner April 27, 2022 13:59
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI check says its fine now, so should be good.

@gilescope
Copy link
Contributor Author

bot merge

1 similar comment
@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit c4693eb into master Apr 27, 2022
@paritytech-processbot paritytech-processbot bot deleted the giles-bad-choice-of-nightly branch April 27, 2022 17:19
wischli added a commit to KILTprotocol/kilt-node that referenced this pull request Jun 2, 2022
wischli added a commit to KILTprotocol/kilt-node that referenced this pull request Jun 8, 2022
* wip: upgrade to Polkadot v0.9.22

* wip: upgrade to Polkadot v0.9.23

* fix: remove deprecated migrations

NOTE: StorageVersion is tracked inside pallet macro

* fix: fee calc

paritytech/substrate#11415

* chore: bump deps

* fix: add missing check for non zero sender

paritytech/substrate#10413

* fix: client changes

* refactor: downgrade nightly

paritytech/substrate#11266

* chore: upgrade to latest nightly supported by Substrate

* fix: clippy

* fix: clippy

* ci: bump srtool to 1.60

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs

* fix: rilt spec

* fix: remove wip unused file

* chore: bump deps

Co-authored-by: kiltbot <>
godcodehunter pushed a commit to sensoriumxr/substrate that referenced this pull request Jun 22, 2022
* The 2022-02-10 nightly can't build some deps

There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method.

* removing duplicate test

* [ci] add job cargo-check-nixos

* add dummy variables nix check

* fix check-dependent jobs

* fix check-dependent-project template

Co-authored-by: alvicsam <alvicsam@gmail.com>
ntn-x2 pushed a commit to KILTprotocol/kilt-node that referenced this pull request Jun 23, 2022
* wip: upgrade to Polkadot v0.9.22

* wip: upgrade to Polkadot v0.9.23

* fix: remove deprecated migrations

NOTE: StorageVersion is tracked inside pallet macro

* fix: fee calc

paritytech/substrate#11415

* chore: bump deps

* fix: add missing check for non zero sender

paritytech/substrate#10413

* fix: client changes

* refactor: downgrade nightly

paritytech/substrate#11266

* chore: upgrade to latest nightly supported by Substrate

* fix: clippy

* fix: clippy

* ci: bump srtool to 1.60

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs

* fix: rilt spec

* fix: remove wip unused file

* chore: bump deps

Co-authored-by: kiltbot <>
(cherry picked from commit 5e2fec6)
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* The 2022-02-10 nightly can't build some deps

There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method.

* removing duplicate test

* [ci] add job cargo-check-nixos

* add dummy variables nix check

* fix check-dependent jobs

* fix check-dependent-project template

Co-authored-by: alvicsam <alvicsam@gmail.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* The 2022-02-10 nightly can't build some deps

There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method.

* removing duplicate test

* [ci] add job cargo-check-nixos

* add dummy variables nix check

* fix check-dependent jobs

* fix check-dependent-project template

Co-authored-by: alvicsam <alvicsam@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants