Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add Proof Size to Weight Output #11637

Merged
merged 114 commits into from
Jan 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
114 commits
Select commit Hold shift + click to select a range
02d79f4
initial impl
shawntabrizi Jun 10, 2022
0c8651c
add template test
shawntabrizi Jun 10, 2022
6571394
linear fit proof size
shawntabrizi Jun 10, 2022
9d22002
always record proof when tracking storage
shawntabrizi Jun 10, 2022
b05dca2
calculate worst case pov
shawntabrizi Jun 11, 2022
04e8d61
remove duplicate worst case
shawntabrizi Jun 11, 2022
1ab7c34
Merge branch 'master' of https://github.com/paritytech/substrate into…
Jun 11, 2022
1d6d2e7
cargo run --quiet --profile=production --features=runtime-benchmarks…
Jun 11, 2022
5d52c9c
more comment output
shawntabrizi Jun 11, 2022
34c4467
Merge branch 'shawntabrizi-pov-in-cli' of https://github.com/parityte…
shawntabrizi Jun 11, 2022
97acc2d
add cli for worst case map size
shawntabrizi Jun 11, 2022
651f347
update name
shawntabrizi Jun 11, 2022
9d0bdf9
clap does not support underscores
shawntabrizi Jun 11, 2022
7c542d8
rename
shawntabrizi Jun 11, 2022
625593e
expose worst case map values
shawntabrizi Jun 12, 2022
dfc55b4
Merge branch 'master' of https://github.com/paritytech/substrate into…
Jun 12, 2022
49c8132
improve some comments
shawntabrizi Jun 12, 2022
baeddb3
cargo run --quiet --profile=production --features=runtime-benchmarks…
Jun 12, 2022
9d11567
Merge branch 'shawntabrizi-pov-in-cli' of https://github.com/parityte…
shawntabrizi Jun 12, 2022
232cb97
Merge branch 'master' into shawntabrizi-pov-in-cli
shawntabrizi Jun 12, 2022
7a9a3d8
update template
shawntabrizi Jun 12, 2022
6a0cf76
Merge branch 'master' of https://github.com/paritytech/substrate into…
Jun 13, 2022
c8cd738
cargo run --quiet --profile=production --features=runtime-benchmarks…
Jun 13, 2022
7c55e48
Merge branch 'master' into shawntabrizi-pov-in-cli
shawntabrizi Jul 10, 2022
e5e549f
Merge branch 'master' into shawntabrizi-pov-in-cli
shawntabrizi Aug 9, 2022
8b272c4
fix fmt
shawntabrizi Aug 9, 2022
f2baa71
more fmt
shawntabrizi Aug 9, 2022
3b44d68
more fmt
shawntabrizi Aug 10, 2022
26daf32
Merge branch 'master' into shawntabrizi-pov-in-cli
shawntabrizi Sep 7, 2022
b6f849b
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
ggwpez Oct 14, 2022
b5fedc4
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
ggwpez Dec 2, 2022
a5ddf1f
Dont panic when there is no proof
ggwpez Dec 17, 2022
c0a4bc5
Fix test features
ggwpez Dec 17, 2022
3108f6a
Whitelist :extrinsic_index
ggwpez Dec 17, 2022
8eb47ec
Use whitelist when recording proof
ggwpez Dec 17, 2022
309c0cb
Add logs
ggwpez Dec 17, 2022
9926aef
Add PoV testing pallet
ggwpez Dec 17, 2022
96a4b0d
Deploy PoV testing pallet
ggwpez Dec 17, 2022
c48bcc9
Storage benches reside in the PoV pallet
ggwpez Dec 17, 2022
824785d
Linear regress PoV per component
ggwpez Dec 17, 2022
27a335b
Put PoV into the weight templates
ggwpez Dec 17, 2022
21d89aa
fmt
ggwpez Dec 17, 2022
9e7a9f9
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
ggwpez Dec 17, 2022
ba83ba6
Extra alanysis choise for PoV
ggwpez Dec 17, 2022
879cf5b
Add+Fix tests
ggwpez Dec 17, 2022
2b19fa1
Make benches faster
ggwpez Dec 17, 2022
b1f89b8
Cleanup
ggwpez Dec 17, 2022
c19e84a
Use same template comments
ggwpez Dec 19, 2022
66a2d9b
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
ggwpez Dec 19, 2022
9da76e0
".git/.scripts/bench-bot.sh" pallet dev pallet_balances
Dec 19, 2022
cca1f74
".git/.scripts/bench-bot.sh" pallet dev pallet_democracy
Dec 19, 2022
170c358
Update referenda mock BlockWeights
ggwpez Dec 19, 2022
afb4a88
Take measured value size into account
ggwpez Dec 20, 2022
774b383
clippy
ggwpez Dec 20, 2022
43b2cdb
Merge branch 'master' of https://github.com/paritytech/substrate into…
Dec 20, 2022
cd5b536
".git/.scripts/bench-bot.sh" pallet dev pallet_scheduler
Dec 20, 2022
8ddaa2f
WIP
ggwpez Dec 21, 2022
fe5caf9
proof_size: None
ggwpez Dec 21, 2022
c34b538
WIP
ggwpez Dec 22, 2022
d69e0c4
WIP
ggwpez Dec 22, 2022
dc1410f
WIP
ggwpez Dec 22, 2022
906c60e
ugly, but works
ggwpez Dec 22, 2022
1e02140
WIP
ggwpez Dec 22, 2022
5595b55
WIP
ggwpez Dec 22, 2022
3a39968
WIP
ggwpez Dec 22, 2022
74dde1e
wup
ggwpez Dec 22, 2022
61b749e
WIP
ggwpez Dec 22, 2022
2e96402
WIP
ggwpez Dec 22, 2022
3991122
WIP
ggwpez Dec 22, 2022
4c84f87
WIP
ggwpez Dec 22, 2022
3bc2ec5
Add pov_mode attribute to the benchmarks! macro
ggwpez Jan 4, 2023
f2b8c8e
Use pov_mode attribute in PoV benchmarking
ggwpez Jan 4, 2023
b000667
Update tests
ggwpez Jan 4, 2023
8e631b3
Scheduler, Whitelist: Add pov_mode attr
ggwpez Jan 4, 2023
2f3ac23
Update PoV weights
Jan 4, 2023
5acb33a
Add CLI arg: default-pov-mode
ggwpez Jan 4, 2023
e2006ed
Fix tests
ggwpez Jan 4, 2023
21b1c64
fmt
ggwpez Jan 4, 2023
442394a
Merge remote-tracking branch 'server/oty-proof-size-attribute' into s…
ggwpez Jan 4, 2023
0a4829d
fix
ggwpez Jan 4, 2023
697eef7
Revert "Update PoV weights"
ggwpez Jan 4, 2023
95bfa49
Revert "WIP"
ggwpez Jan 4, 2023
467477e
Revert first approach
ggwpez Jan 4, 2023
debbc07
Clippy
ggwpez Jan 4, 2023
213e340
Add extra benchmarks
ggwpez Jan 4, 2023
9fe83c5
Merge branch 'master' of https://github.com/paritytech/substrate into…
Jan 4, 2023
a82f20a
".git/.scripts/commands/bench/bench.sh" pallet dev pallet_alliance
Jan 4, 2023
46fa61a
".git/.scripts/commands/bench/bench.sh" pallet dev pallet_whitelist
Jan 4, 2023
81e6723
".git/.scripts/commands/bench/bench.sh" pallet dev pallet_scheduler
Jan 4, 2023
9ac907d
fmt
ggwpez Jan 4, 2023
637641b
Clippy
ggwpez Jan 4, 2023
9bd0c3d
Clippy 🤦
ggwpez Jan 4, 2023
1b87727
Add reference benchmarks
ggwpez Jan 5, 2023
29b8eed
Fix doc comments
ggwpez Jan 5, 2023
c52210f
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
Jan 6, 2023
3dd9a4c
Undo logging
ggwpez Jan 7, 2023
44dce06
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
ggwpez Jan 7, 2023
6bc569b
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
ggwpez Jan 20, 2023
a4bd72c
Add 'Ignored' pov_mode
ggwpez Jan 20, 2023
52f460b
Allow multiple attributes per benchmark
ggwpez Jan 23, 2023
4ea47d9
Validate pov_mode syntax
ggwpez Jan 23, 2023
8878ab0
Ignore PoV for all contract benchmarks
ggwpez Jan 23, 2023
5af9771
Test
ggwpez Jan 23, 2023
b5438b2
test
ggwpez Jan 23, 2023
545f26f
Bump macro recursion limit
ggwpez Jan 23, 2023
fc33556
fmt
ggwpez Jan 23, 2023
b77fb33
Update contract weights
ggwpez Jan 23, 2023
d988e35
Merge remote-tracking branch 'origin/master' into shawntabrizi-pov-in…
ggwpez Jan 23, 2023
20633ea
fix test ffs
ggwpez Jan 23, 2023
4a6a3e7
pov_mode is unsupported in V2 syntax
ggwpez Jan 23, 2023
f45c2f8
Fix pallet ui tests
ggwpez Jan 23, 2023
74f84d6
update pallet ui
ggwpez Jan 24, 2023
2674325
Fix pallet ui tests
ggwpez Jan 24, 2023
047cf4f
Update weights
ggwpez Jan 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more fmt
  • Loading branch information
shawntabrizi committed Aug 10, 2022
commit 3b44d68940fd560dd3601c378302d29f75c71bd5
4 changes: 2 additions & 2 deletions .maintain/frame-weight-template.hbs
Original file line number Diff line number Diff line change
@@ -69,7 +69,7 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Worst Case: `{{benchmark.worst_case_proof_size}}` bytes
// Base: `{{benchmark.base_proof_size}}` bytes
{{#each benchmark.component_proof_size as |cp|}}
/// PoV component: `{{cp.name}} * {{cp.slope}}` with slope stddev `{{underscore cp.error}}`.
// PoV component: `{{cp.name}} * {{cp.slope}}` with slope stddev `{{underscore cp.error}}`.
{{/each}}
({{underscore benchmark.base_weight}} as Weight)
{{#each benchmark.component_weight as |cw|}}
@@ -110,7 +110,7 @@ impl WeightInfo for () {
// Worst Case: `{{benchmark.worst_case_proof_size}}` bytes
// Base: `{{benchmark.base_proof_size}}` bytes
{{#each benchmark.component_proof_size as |cp|}}
/// PoV component: `{{cp.name}} * {{cp.slope}}` with slope stddev `{{underscore cp.error}}`.
// PoV component: `{{cp.name}} * {{cp.slope}}` with slope stddev `{{underscore cp.error}}`.
{{/each}}
({{underscore benchmark.base_weight}} as Weight)
{{#each benchmark.component_weight as |cw|}}
12 changes: 6 additions & 6 deletions frame/assets/src/weights.rs
Original file line number Diff line number Diff line change
@@ -112,9 +112,9 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size
// Worst Case: `10840` bytes
// Base: `5149` bytes
/// PoV component: `c * 240` with slope stddev `0`.
/// PoV component: `s * 240` with slope stddev `0`.
/// PoV component: `a * 122` with slope stddev `0`.
// PoV component: `c * 240` with slope stddev `0`.
// PoV component: `s * 240` with slope stddev `0`.
// PoV component: `a * 122` with slope stddev `0`.
(0 as Weight)
// Standard Error: `36_000`
.saturating_add((17_579_000 as Weight).saturating_mul(c as Weight))
@@ -418,9 +418,9 @@ impl WeightInfo for () {
// Proof Size
// Worst Case: `10840` bytes
// Base: `5149` bytes
/// PoV component: `c * 240` with slope stddev `0`.
/// PoV component: `s * 240` with slope stddev `0`.
/// PoV component: `a * 122` with slope stddev `0`.
// PoV component: `c * 240` with slope stddev `0`.
// PoV component: `s * 240` with slope stddev `0`.
// PoV component: `a * 122` with slope stddev `0`.
(0 as Weight)
// Standard Error: `36_000`
.saturating_add((17_579_000 as Weight).saturating_mul(c as Weight))
2 changes: 1 addition & 1 deletion utils/frame/benchmarking-cli/src/pallet/template.hbs
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ impl<T: frame_system::Config> {{pallet}}::WeightInfo for WeightInfo<T> {
// Worst Case: `{{benchmark.worst_case_proof_size}}` bytes
// Base: `{{benchmark.base_proof_size}}` bytes
{{#each benchmark.component_proof_size as |cp|}}
/// PoV component: `{{cp.name}} * {{cp.slope}}` with slope stddev `{{underscore cp.error}}`.
// PoV component: `{{cp.name}} * {{cp.slope}}` with slope stddev `{{underscore cp.error}}`.
{{/each}}
({{underscore benchmark.base_weight}} as Weight)
{{#each benchmark.component_weight as |cw|}}