Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use fungible token traits in alliance pallet #11955

Closed
wants to merge 1 commit into from

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Aug 1, 2022

Replaces the ReservableCurrency trait bound on the Currency associated type for pallet_alliance::Config with fungible::BalancedHold.

Related to #8285 and paritytech/polkadot-sdk#327.

I may have jumped the gun here as the logic for BalancedHold::slash_held is different from ReservableCurrency::slash_reserved, so we may instead have to fix that first.

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 1, 2022
@joepetrowski
Copy link
Contributor

In general I think moving to these traits is a good thing. However, there are some runtime features that interact with reserved/slashed assets, e.g. https://github.com/paritytech/cumulus/pull/1433/files, that we're quite far into testing locally and on Westend. I'd prefer to launch the Collectives chain using the balances as they are now because we have high confidence that they are safe. Then we can give this more attention, auditing, and testing and migrate to it in an upgrade.

@ggwpez ggwpez added D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 11, 2022
@stale
Copy link

stale bot commented Sep 10, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Sep 10, 2022
@stale stale bot closed this Sep 25, 2022
@louismerlin louismerlin removed the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants