-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Uniques: Allowing multiple approvals #12164
Conversation
Hi @Szegoo , thanks for your contribution! |
@jsidorenko What would be the benefit of creating a /// The approved transferrer of this item, if one is set.
pub(super) approved:
BoundedVec<(AccountId, Option<<T as frame_system::Config>::BlockNumber>), ApprovalsLimit>, I am going to use |
|
/// New metadata has been set for a `collection`. | ||
CollectionMetadataSet { | ||
collection: T::CollectionId, | ||
data: BoundedVec<u8, T::StringLimit>, | ||
is_frozen: bool, | ||
}, | ||
/// Metadata has been cleared for a `collection`. | ||
CollectionMetadataCleared { collection: T::CollectionId }, | ||
CollectionMetadataCleared { | ||
collection: T::CollectionId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to run rustup update
and then: cargo +nightly fmt
The latest fmt shouldn't change the syntax that way
@jsidorenko I opened a new PR with these changes to the js/uniques-v2-main-branch, Should I close this? |
Solves the
new approvals structure
task from #11783In short, this PR allows the item owner to make approvals to multiple accounts.
Note: I took a bit of a different approach than proposed in #11791. I believe that this is a bit simpler than storing a
BoundedBTreeMap
for approvals.