Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add special tag to exclude runtime storage items from benchmarking #12205

Merged
merged 72 commits into from
Sep 16, 2022
Merged

Add special tag to exclude runtime storage items from benchmarking #12205

merged 72 commits into from
Sep 16, 2022

Commits on Sep 12, 2022

  1. initial setup

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f08d3ae View commit details
    Browse the repository at this point in the history

  2. add WhitelistedStorageKeys trait

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    c381aef View commit details
    Browse the repository at this point in the history

  3. add (A, B) tuple implementation for whitelisted_storage_keys()

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    1275c42 View commit details
    Browse the repository at this point in the history

  4. fix formatting

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    84beb0f View commit details
    Browse the repository at this point in the history

  5. implement WhitelistedStorageKeys for all tuple combinations

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3699c19 View commit details
    Browse the repository at this point in the history

  6. impl_for_tuples up to 128 for WhitelistedStorageKeys

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3056275 View commit details
    Browse the repository at this point in the history

  7. refactor to #[benchmarking(cached)]

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    adc7585 View commit details
    Browse the repository at this point in the history

  8. tweak error message and mark BlockNumber as cached

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f645511 View commit details
    Browse the repository at this point in the history

  9. add benchmarking(cached) to the other default types

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    1b8af15 View commit details
    Browse the repository at this point in the history

  10. add docs for benchmarking(cached)

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    2a1ae01 View commit details
    Browse the repository at this point in the history

  11. properly parse storage type declaration

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    586bafb View commit details
    Browse the repository at this point in the history

  12. make storage_alias structs public so we can use them in this macro

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    cfcd073 View commit details
    Browse the repository at this point in the history

  13. use BTreeMap since TrackedStorageKey missing Ord outside of std

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    8534891 View commit details
    Browse the repository at this point in the history

  14. make WhitelistedStorageKeys accessible

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    e2550b4 View commit details
    Browse the repository at this point in the history

  15. basic detection of benchmarking(cached) 💥

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    157fb29 View commit details
    Browse the repository at this point in the history

  16. proper parsing of #[benchmarking(cached)] from pallet parse macro

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    5318167 View commit details
    Browse the repository at this point in the history

  17. store presence of #[benchmarking(cached)] macro on StorageDef 

    * will be used for later expansion
    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    8cde8fe View commit details
    Browse the repository at this point in the history

  18. compiling blank impl for WhitelistedStorageKeys

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4cccd8a View commit details
    Browse the repository at this point in the history

  19. move impl to expand_pallet_struct

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f21315c View commit details
    Browse the repository at this point in the history

  20. use frame_support::sp_std::vec::Vec properly

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    faa63a7 View commit details
    Browse the repository at this point in the history

  21. successfully compiling with storage info loaded into a variable 💥

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    73b01f1 View commit details
    Browse the repository at this point in the history

  22. plausible implementation for whitelisted_storage_keys() 

    * depends on the assumption that storage_info.encode() can be loaded
  into TrackedStorageKey::new(..)
    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    fc6d239 View commit details
    Browse the repository at this point in the history

  23. use Pallet::whitelisted_storage_keys() instead of hard-coded list

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f920bb9 View commit details
    Browse the repository at this point in the history

  24. AllPallets::whitelisted_storage_keys() properly working 💥

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    0040a45 View commit details
    Browse the repository at this point in the history

  25. collect storage names

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4a0fe7f View commit details
    Browse the repository at this point in the history

  26. whitelisted_storage_keys() impl working 💥

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    8ab6ab3 View commit details
    Browse the repository at this point in the history

  27. clean up

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    8ca026e View commit details
    Browse the repository at this point in the history

  28. fix compiler error

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    58a6229 View commit details
    Browse the repository at this point in the history

  29. just one compiler error

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    854a102 View commit details
    Browse the repository at this point in the history

  30. fix doc compiler error

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    771202c View commit details
    Browse the repository at this point in the history

  31. use better import path

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    fe856ac View commit details
    Browse the repository at this point in the history

  32. fix comment

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    0936ca4 View commit details
    Browse the repository at this point in the history

  33. whoops

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    a72a280 View commit details
    Browse the repository at this point in the history

  34. whoops again

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    c4ecb9a View commit details
    Browse the repository at this point in the history

  35. fix macro import issue

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    c6fd281 View commit details
    Browse the repository at this point in the history

  36. cargo fmt

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f360944 View commit details
    Browse the repository at this point in the history

  37. mark example as ignore

    @sam0x17
    sam0x17 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    92d5f5e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. use keyword tokens instead of string parsing

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    da51def View commit details
    Browse the repository at this point in the history

  2. fix keyword-based parsing of benchmarking(cached)

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e00420f View commit details
    Browse the repository at this point in the history

  3. preliminary spec for check_whitelist()

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a63acdf View commit details
    Browse the repository at this point in the history

  4. add additional test for benchmarking whitelist

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    1a0ba3f View commit details
    Browse the repository at this point in the history

  5. add TODO note

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    d0ee2c6 View commit details
    Browse the repository at this point in the history

  6. remove irrelevant line from example

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2d1d637 View commit details
    Browse the repository at this point in the history

  7. use filter_map instead of filter and map

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    9ce39d2 View commit details
    Browse the repository at this point in the history

  8. simplify syntax 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @sam0x17 @KiChjang
    sam0x17 and KiChjang committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    33828ea View commit details
    Browse the repository at this point in the history

  9. clean up

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    49b13ac View commit details
    Browse the repository at this point in the history

  10. fix test

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a2e8185 View commit details
    Browse the repository at this point in the history

  11. fix tests

    @sam0x17
    sam0x17 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    557a0c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. use keyword parsing instead of string parsing

    @sam0x17
    sam0x17 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    d20bfe9 View commit details
    Browse the repository at this point in the history

  2. use collect() instead of a for loop 

    Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
    @sam0x17 @kianenigma
    sam0x17 and kianenigma committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    1d31abe View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. fix compiler error

    @sam0x17
    sam0x17 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    dcb6312 View commit details
    Browse the repository at this point in the history

  2. clean up benchmarking(cached) marking code

    @sam0x17
    sam0x17 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    6e66eb1 View commit details
    Browse the repository at this point in the history

  3. use cloned()

    @sam0x17
    sam0x17 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    dcda735 View commit details
    Browse the repository at this point in the history

  4. refactor to not use panic! and remove need for pub types in storage_a… 

    …lias
    @sam0x17
    sam0x17 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    3f7bbc5 View commit details
    Browse the repository at this point in the history

  5. remove unneeded use 

    Co-authored-by: Bastian Köcher <info@kchr.de>
    @sam0x17 @bkchr
    sam0x17 and bkchr committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    975f371 View commit details
    Browse the repository at this point in the history

  6. remove unneeded visibility changes

    @sam0x17
    sam0x17 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    5ff3623 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. don't manually hard code hash for treasury account as hex

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    7214d0f View commit details
    Browse the repository at this point in the history

  2. proper Ord, PartialOrd, and Hash impls for TrackedStorageKey 

    * now based just on key, and available in no-std
    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    6e49069 View commit details
    Browse the repository at this point in the history

  3. use BTreeSet instead of BTreeMap

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    4a71bd4 View commit details
    Browse the repository at this point in the history

  4. fix comments

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    7752321 View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    72a8ac8 View commit details
    Browse the repository at this point in the history

  6. switch to pallet::whitelist and re-do it basti's way :D

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    20e1375 View commit details
    Browse the repository at this point in the history

  7. make PartialOrd for TrackedStorageKey consistent with Ord

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    eb46fbb View commit details
    Browse the repository at this point in the history

  8. more correct implementation of hash-related traits for TrackedStorageKey

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    fd23e9e View commit details
    Browse the repository at this point in the history

  9. fix integration test

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    d483a7a View commit details
    Browse the repository at this point in the history

  10. update TODO

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    05db4e5 View commit details
    Browse the repository at this point in the history

  11. remove unused keyword

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    cb4ed97 View commit details
    Browse the repository at this point in the history

  12. remove more unused keywords

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    4faf150 View commit details
    Browse the repository at this point in the history

  13. use into_iter() 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @sam0x17 @KiChjang
    sam0x17 and KiChjang committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    91f33f0 View commit details
    Browse the repository at this point in the history

  14. Update frame/support/procedural/src/pallet/parse/mod.rs 

    Co-authored-by: Bastian Köcher <info@kchr.de>
    @sam0x17 @bkchr
    sam0x17 and bkchr committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    42127fc View commit details
    Browse the repository at this point in the history

  15. add docs for whitelisted

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    cbf5959 View commit details
    Browse the repository at this point in the history

  16. fix comment

    @sam0x17
    sam0x17 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    ae1bf10 View commit details
    Browse the repository at this point in the history