This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Move bitswap to its own crate #12242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the bitswap protocol out of `sc-network` to its own crate.
altonen
added
A0-please_review
altonen
requested review from
kpp,
skunert,
bkchr,
dmitry-markin and
arkpar
arkpar
approved these changes
Sep 12, 2022
kpp
approved these changes
Sep 12, 2022
dmitry-markin
approved these changes
Sep 12, 2022
kpp
reviewed
Sep 12, 2022
kpp
reviewed
Sep 12, 2022
|
bot merge |
|
A bit late to the party 😬 As far as I see his newly added field block_request_protocol_config in the network params is currently not used. Should it not be passed here together with the protocols from |
|
Was this properly tested with an ipfs client? |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Introduce `sc-network-bitswap` Move the bitswap protocol out of `sc-network` to its own crate. * Improve test coverage * Remove mention of bitswap from `sc-network` * Fix documentation * Fix clippy and remove the void dependency * Remove unneeded trait bound and bump prost to 0.11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move bitswap protocol to its own crate and improve test coverage for the protocol. Fixes the second bullet from #12133
polkadot companion: paritytech/polkadot#5994