This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
frame-support-test: migrate tests from decl_* macros to the new pallet macros
#12445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
changed the title
decl_* macros to the new pallet macros
|
Maybe I should use By now, I removed the |
kianenigma
approved these changes
Oct 11, 2022
|
@kianenigma I think #12401 could be reviewed and merged firstly? |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
stale
bot
removed
the
A5-stale
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
reviewed
Apr 28, 2023
| /// sufficient balance to cover the minimum stake for the role. | ||
| /// Bonding only occurs after successful entry into a role. | ||
| #[pallet::storage] | ||
| #[pallet::getter(fn role_entry_requests)] |
There was a problem hiding this comment.
I will keep the getters in the tests as we should remove them here last IMHO as to not accidentally break them.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
B0-silent
|
bot rebase |
|
Rebased |
|
bot rebase |
|
Rebased |
ggwpez
approved these changes
May 8, 2023
|
bot merge |
|
/tip large (combined tip together for #12401, therefore large) |
|
@ggwpez Contributor did not properly post their account address. Make sure the pull request description has: "{network} address: {address}". |
|
showerthought: would be cool if they could just specify it in their github bio 🤔 |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…llet` macros (paritytech#12445) * frame-support: migrate some tests from decl macros to new pallet attribute macros * Remove useless type alias * Remove useless type alias * frame-support-test: migrate old decl_macros to new pallet attribute macros * fmt Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix features Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Remove deprecated stuff Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update UI tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix UI test Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix test Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update UI tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Cleanup Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR is a part of #12248 and it need #12401 to be merged firstly
In this PR, I migrate the tests of
frame/support/testfrom olddecl_*macros to the newpalletattribute macros, and remove some useless tests.After this, I will remove the
decl_*macros and do some other trivial things.