This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
BlockId removal: refactor: Backend::state_at #12488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
added
B0-silent
bkchr
approved these changes
Oct 13, 2022
dmitry-markin
approved these changes
Oct 13, 2022
This was referenced Oct 13, 2022
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#6149 |
koute
approved these changes
Oct 14, 2022
|
bot merge |
|
Waiting for commit status. |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Minor naming improved * BlockId removal refactor: Backend::state_at * formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the argument of
Backend::state_atfrom:block: BlockId<Block>to:hash: &Block::HashThis PR is part of
BlockId::Numberrefactoring analysis (paritytech/polkadot-sdk#53) .HeaderBackend::expect_block_hash_from_idwas used to convertBlockIdtoBlock::Hash.polkadot companion: paritytech/polkadot#6149
cumulus companion: paritytech/cumulus#1760