Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[DO NOT MERGE] Nomination Pool Commission #12511

Closed
wants to merge 236 commits into from
Closed

[DO NOT MERGE] Nomination Pool Commission #12511

wants to merge 236 commits into from

Conversation

rossbulat
Copy link

@rossbulat rossbulat commented Oct 17, 2022 •
edited
Loading

PR moved to #13128

@rossbulat rossbulat added A0-please_review Pull request needs code review. A3-in_progress Pull request is in progress. No review needed at this stage. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Oct 17, 2022
@github-actions github-actions bot removed the A0-please_review Pull request needs code review. label Oct 17, 2022
@rossbulat rossbulat marked this pull request as ready for review October 17, 2022 14:15
@github-actions github-actions bot removed the A3-in_progress Pull request is in progress. No review needed at this stage. label Oct 17, 2022
skunert and others added 9 commits January 11, 2023 16:20
@skunert
Remove unused code in state-db (#13103)
34febb3
@gpestana
EPM and staking events improvement (#13035)
ae9005c 
* EPM and staking events improvement

* Uses RawOrigin in ElectionCompute event

* Refactors new phase events to PhaseTransition event

* PhaseTransitioned and remove RawOrigin from event

* Adds helpers for epm phase transition and staking force new

* addresses review comments

* nit: removes unecessary clone

* fixes benchmarks

Co-authored-by: parity-processbot <>
@rcny
CI: configure cargo-nextest's reporter options explicitly (#13104)
f61fc7e
@lemunozm
Add ensure_pow method (#13042)
2dd6e73 
* add ensure_pow method

* reexport checked_pow and ensure_pow
@bkchr
Add solution hint to error message (#13111)
db7a1c2 
* Add solution hint to error message

* make it compile

* Update frame/support/procedural/src/pallet/expand/hooks.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update frame/support/procedural/src/pallet/expand/storage.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update frame/support/procedural/src/pallet/expand/storage.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update frame/support/procedural/src/pallet/expand/storage.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

Co-authored-by: Bastian Köcher <git@kchr.de>
@joao-paulo-parity @alvicsam
Avoid unintentionally canceling the scheduled crate publishing job (#…
1a29e81 
…13088)

* avoid unintentionally canceling the scheduled crate publishing job

because publish-crates and publish-crates-manual share the resource group
"crates-publishing", any instance of publish-crates-manual cancels a running
instance of publish-crates, as demonstrated by
https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2212179

a workaround for that unintended interaction is to avoid creating instances of
publish-crates-manual and instead require pipelines to be triggered manually by
checking $CI_JOB_MANUAL == "true"

* check manual pipelines by $CI_PIPELINE_SOURCE instead of $CI_JOB_MANUAL

* make crate-publishing pipelines uninterruptible

* use conditional includes to work around interruptible limitations

* organize comments

* remove interruptible from common pipeline

* wip: check include

* wip: check include

* fix include

* fix include

* fix include

* fix yaml

* fix yaml

* remove shared common-pipeline

* wip: retry common-pipeline

* move .default-template to .gitlab-ci.yml

* fix the pipeline

add comments

* fix default-pipeline.yml

* revert publish-crates-manual to when: manual

* move "needs:" back to publish-crates

* avoid manual repetition

* improve previous commit

* try to avoid manual repetition

* fix indentation

* minor adjustments

* move defaults to top of .gitlab-ci.yml

* fix positioning on default in the diff

* comments

* indentation

* Apply suggestions from code review

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@tonyalaribe @bkchr
introduce log-target constant to more frame pallets (#13116)
fc43b5f 
* introduce log-target constant to more frame pallets

* cargo fmt

* make LOG_TARGET in session public

* Update frame/elections-phragmen/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update frame/elections-phragmen/src/migrations/v3.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update frame/elections-phragmen/src/migrations/v3.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update frame/elections-phragmen/src/migrations/v3.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* move LOG_TARGET=runtime::session_historical to migrations module, where it's actually used

Co-authored-by: Bastian Köcher <git@kchr.de>
@rcny
Update tests for 1.66 and switch CI to stable Rust 1.66 (#13118)
874e3e2 
* Update UI tests for 1.66

* Fix `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66
@joao-paulo-parity
remove update-node-template (#13100)
f39c290 
will be moved to polkadot's pipeline

ref https://github.com/paritytech/release-engineering/issues/142
@rossbulat rossbulat requested a review from a team as a code owner January 11, 2023 09:20
@rossbulat rossbulat changed the title Nomination Pool Commission [DO NOT MERGE] Nomination Pool Commission Jan 12, 2023
@rossbulat rossbulat mentioned this pull request Jan 12, 2023
Merged
@rossbulat rossbulat added E0-patchthis and removed E0-patchthis A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jan 12, 2023
@kianenigma
Copy link
Contributor

should this be closed?

@rossbulat rossbulat closed this Jan 12, 2023
@rossbulat rossbulat deleted the rb-nomination-pool-commission branch February 3, 2023 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruseinov ruseinov Awaiting requested review from ruseinov

@kianenigma kianenigma Awaiting requested review from kianenigma

@athei athei Awaiting requested review from athei

@andresilva andresilva Awaiting requested review from andresilva

@ggwpez ggwpez Awaiting requested review from ggwpez

@gpestana gpestana Awaiting requested review from gpestana

@Ank4n Ank4n Awaiting requested review from Ank4n

Assignees
No one assigned
Labels
None yet
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.